From owner-svn-src-all@freebsd.org  Tue Jan 26 22:58:02 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F109A6EB9F;
 Tue, 26 Jan 2016 22:58:02 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5D2233DF;
 Tue, 26 Jan 2016 22:58:02 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u0QMw0j5015815
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 26 Jan 2016 14:58:01 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u0QMw0jQ015814;
 Tue, 26 Jan 2016 14:58:00 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 26 Jan 2016 14:58:00 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Luigi Rizzo <luigi@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r294855 - head/sys/netpfil/ipfw
Message-ID: <20160126225800.GV6885@FreeBSD.org>
References: <201601262245.u0QMj5Pi095914@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201601262245.u0QMj5Pi095914@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2016 22:58:02 -0000

  Luigi,

On Tue, Jan 26, 2016 at 10:45:05PM +0000, Luigi Rizzo wrote:
L> Modified: head/sys/netpfil/ipfw/dn_heap.c
L> ==============================================================================
L> --- head/sys/netpfil/ipfw/dn_heap.c	Tue Jan 26 22:32:58 2016	(r294854)
L> +++ head/sys/netpfil/ipfw/dn_heap.c	Tue Jan 26 22:45:05 2016	(r294855)
L> @@ -81,7 +81,7 @@ heap_resize(struct dn_heap *h, unsigned 
L>  {
L>  	struct dn_heap_entry *p;
L>  
L> -	if (h->size >= new_size )	/* have enough room */
L> +	if ((unsigned int)h->size >= new_size )	/* have enough room */
L>  		return 0;
L>  #if 1  /* round to the next power of 2 */
L>  	new_size |= new_size >> 1;
L> @@ -419,6 +419,8 @@ dn_ht_init(struct dn_ht *ht, int buckets
L>  static int
L>  do_del(void *obj, void *arg)
L>  {
L> +	(void)obj;
L> +	(void)arg;
L>  	return DNHT_SCAN_DEL;
L>  }

Are there any benefits of this syntax comparing to __unused macro
that expands to proper attribute? The latter syntax is used in
FreeBSD more often.

-- 
Totus tuus, Glebius.