From owner-svn-ports-all@freebsd.org  Tue Jan  2 22:36:15 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD4DDEBD117;
 Tue,  2 Jan 2018 22:36:15 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E7027691D;
 Tue,  2 Jan 2018 22:36:15 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id E4BD618BEF; Tue,  2 Jan 2018 22:36:14 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r457245 - in head/net-p2p: bitcoin litecoin
References: <201712251807.vBPI7mAd012038@repo.freebsd.org>
 <20171226071626.GC27490@FreeBSD.org>
Date: Tue, 02 Jan 2018 23:36:03 +0100
Message-ID: <lghf-nb1o-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jan 2018 22:36:15 -0000

Alexey Dokuchaev <danfe@FreeBSD.org> writes:

> On Mon, Dec 25, 2017 at 06:07:48PM +0000, Jan Beich wrote:
>
>> New Revision: 457245
>> URL: https://svnweb.freebsd.org/changeset/ports/457245
>> 
>> Log:
>>   net-p2p/bitcoin: unbreak with boost 1.66
>>   
>>   PR:		224129 224132
>>   Obtained from:	upstream (Bitcoin 0.16.0)
>>   Approved by:	portmgr blanket
>> 
>> Modified: head/net-p2p/bitcoin/Makefile
>> ...
>> @@ -7,6 +7,9 @@ DISTVERSIONPREFIX=	v
>>  PORTREVISION?=	2
>>  CATEGORIES=	net-p2p finance
>>  
>> +PATCH_SITES=	https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/
>> +PATCHFILES=	1ec0c0a01c31.patch:-p1
> ...
>> 
>> Modified: head/net-p2p/bitcoin/distinfo
>> ...
>> +SIZE (1ec0c0a01c31.patch) = 3535
>
> I'd like to bring to your attention (again) that this approach of fetching
> external patches is fragile and already had broken things in the past.

Well, I did forget but
- PATCHFILES is less error prone, saving me accidental embarrasment
- PATCHFILES sends a strong message there were no modifications
  downstream which maybe important for fixes under blanket against
  security-sensitive software
- PATCHFILES is as mirror-(un)friendly as _GH0 suffix'd distfiles
- USE_GITHUB can be extended to to handle PATCHFILES to establish
  a better declarative style, decrease the number of clumsy commits

r454171 review overacted on the format change, as if GitHub distfiles
never change due to moved tags. The traditional way of backporting
upstream patches was never standardised.

> Putting 3535-byte patch file in ${FILESDIR} is perfectly fine for its size
> (and EXTRA_PATCHES also supports :-p1).

Unconditional EXTRA_PATCHES is a style bug. PHB defines EXTRA_PATCHES
only for conditional usage. Maybe portlint should warn about this.

--
Let's color the bikeshed as green.