From owner-freebsd-ports@freebsd.org Wed Jan 17 18:29:25 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5CFA9E7F623 for ; Wed, 17 Jan 2018 18:29:25 +0000 (UTC) (envelope-from martin@waschbuesch.de) Received: from relay01.waschbuesch.it (relay01.waschbuesch.it [IPv6:2a00:cba0:100::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.waschbuesch.it", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1B98C7B85F for ; Wed, 17 Jan 2018 18:29:25 +0000 (UTC) (envelope-from martin@waschbuesch.de) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=waschbuesch.de; s=dkim; h=References:To:Cc:In-Reply-To:Date:Subject: Mime-Version:Content-Type:Message-Id:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cbv8qeA9bYtGrA2Omeyp4qBrg9q28l+pQwJ2+xBh8CU=; b=YQER9CX4QfzUyw2EuzrOpHgdQ 9ghG9wQ0n7PJbdX8RCcLRykdA0pvMydQxTReVFbBQI3nluMn4nwmrPf76Ym9YPHlHIlDkmRfwzhiI NKbZriY+I4w+JCSMu7eBGSBTNB7fAH26cgzV5NNZnjeJ+QvzxBbJRKnKsAkRpAmNsj5os=; Received: by relay01.waschbuesch.it with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim) (envelope-from ) id 1ebsSS-000Lbs-6J; Wed, 17 Jan 2018 18:29:09 +0000 From: =?utf-8?Q?Martin_Waschb=C3=BCsch?= Message-Id: Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: Help with versioning scheme Date: Wed, 17 Jan 2018 19:29:06 +0100 In-Reply-To: Cc: freebsd-ports@freebsd.org To: Adam Weinberger References: X-Mailer: Apple Mail (2.3445.5.20) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 18:29:25 -0000 Hi Adam, > Am 17.01.2018 um 19:19 schrieb Adam Weinberger : > Hi Martin, >=20 > You don't want to use the upstream version to represent PORTREVISION. = PORTREVISION is for when you need to force rebuilds of the port itself, = and so tying it to upstream would make it impossible to bump it = ourselves. >=20 > Why do you need to ignore the fourth digit? It's perfectly valid for = our purposes. So far, I had (because it coincided with their version number) used it = to provide SO_VER. But that breaks now: --- # Created by: adamw # $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z = sunpoet $ PORTNAME=3D lz4 PORTVERSION=3D 1.8.1 DISTVERSIONPREFIX=3D v PORTEPOCH=3D 1 CATEGORIES=3D archivers PKGNAMEPREFIX=3D lib MAINTAINER=3D martin@waschbuesch.de COMMENT=3D LZ4 compression library, lossless and very fast LICENSE=3D BSD2CLAUSE GPLv2 LICENSE_COMB=3D multi USES=3D gmake pathfix pkgconfig USE_GITHUB=3D yes USE_LDCONFIG=3D yes #PATHFIX_MAKEFILEIN=3D Makefile ALL_TARGET=3D default # don't remove this SO_VER=3D ${PORTVERSION} PLIST_SUB+=3D SO_VER=3D${SO_VER} SO_VER_MAJ=3D${SO_VER:R:R} LIBDIR=3D ${PREFIX}/lib post-patch: @${FIND} ${WRKSRC} -name Makefile | ${XARGS} ${REINPLACE_CMD} \ -e '/^MANDIR :=3D/s|share/||' @${REINPLACE_CMD} -e '/^all:/s/$$/ liblz4.pc/' \ ${WRKSRC}/lib/Makefile @${REINPLACE_CMD} -e '/^all:/s|fullbench.*||' \ ${WRKSRC}/programs/Makefile post-install: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/lz4* ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblz4.so.${SO_VER} .include --- Manually specifying the SO_VER seems also very weird. I am sorry if these questions seem clumsy - I am not terribly = experienced with porting stuff, but eager to learn.=