From owner-freebsd-stable@freebsd.org Mon Mar 12 17:37:48 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C58ABF2F02D for ; Mon, 12 Mar 2018 17:37:47 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F1A487D19 for ; Mon, 12 Mar 2018 17:37:46 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: f2239e46-261b-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id f2239e46-261b-11e8-b951-f99fef315fd9; Mon, 12 Mar 2018 17:36:51 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2CHbggJ016811; Mon, 12 Mar 2018 11:37:42 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1520876261.84937.222.camel@freebsd.org> Subject: Re: zfs problems after rebuilding system [SOLVED] From: Ian Lepore To: Pete French , freebsd-stable@freebsd.org Date: Mon, 12 Mar 2018 11:37:41 -0600 In-Reply-To: <831aa29b-6464-eb6c-e9c9-058963756ec8@ingresso.co.uk> References: <21c64a2d-b9f9-24c8-88ec-ff1210891f60@zyxst.net> <65372449-53f1-8002-981a-e20f4a592e26@zyxst.net> <5CFC89E9-57BE-4CB7-9C55-0D3CCF1E8D3D@FreeBSD.org> <20180303234236.M3811@besplex.bde.org> <9b3cd942-347c-44a2-60d6-0b3c4a45552f@ingresso.co.uk> <1520723109.84937.136.camel@freebsd.org> <84146241-12d3-8333-0687-c2377838f175@ingresso.co.uk> <1520723722.84937.139.camel@freebsd.org> <217437b9-9879-8919-966a-45cf5eb58d33@ingresso.co.uk> <1520725685.84937.144.camel@freebsd.org> <831aa29b-6464-eb6c-e9c9-058963756ec8@ingresso.co.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 17:37:48 -0000 On Mon, 2018-03-12 at 17:21 +0000, Pete French wrote: > > On 10/03/2018 23:48, Ian Lepore wrote: > > > > I based my fix heavily on that patch from the PR, but I rewrote it > > enough that I might've made any number of mistakes, so it needs fresh > > testing.  The main change I made was to make it a lot less noisy while > > waiting (it only mentions the wait once, unless bootverbose is set, in > > which case it's once per second).  I also removed the logic that > > limited the retries to nfs and zfs, because I think we can remove all > > the old code related to waiting that only worked for ufs and let this > > new retry be the way it waits for all filesystems.  But that's a bigger > > change we can do separately; I didn't want to hold up this fix any > > longer. > TThansk for the patch, its is very much appercaited! I applied this  > earlier today, and have been continuously rebooting the machine in Azure  > ever since (every ten minutes). This has worked flawlessly, so I am very  > happy that this fixes the issue for me. I am going to leave it running  > though, just to see if anything happens. I havent examined dmesg, but I  > thould be able to see the output from the patch there to verify that its  > waiting, yes ? > > cheers, > > -pete. Yes, if the root filesystem isn't available on the first attempt, it should emit a single line saying it will wait for up to N seconds for it to arrive, where N is the vfs.mountroot.timeout value (3 seconds if not set in loader.conf). -- Ian