From owner-freebsd-ports-bugs@freebsd.org Thu Sep 20 14:24:35 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF830109E5C0 for ; Thu, 20 Sep 2018 14:24:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5C98C8F701 for ; Thu, 20 Sep 2018 14:24:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2166C109E5BD; Thu, 20 Sep 2018 14:24:34 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F389E109E5BC for ; Thu, 20 Sep 2018 14:24:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 93DEC8F6FE for ; Thu, 20 Sep 2018 14:24:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C8ABF15939 for ; Thu, 20 Sep 2018 14:24:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w8KEOWsC012098 for ; Thu, 20 Sep 2018 14:24:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w8KEOWZu012097 for ports-bugs@FreeBSD.org; Thu, 20 Sep 2018 14:24:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 218515] [NEW PORT] devel/naken_asm: Assembler/disassembler multiple CPUs Date: Thu, 20 Sep 2018 14:24:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 14:24:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218515 --- Comment #3 from Tobias Kortkamp --- (In reply to mike from comment #2) XPORTVERSION=3D 2017.04.09 XDISTNAME=3D naken_asm-2017-04-09 Remove both and set DISTVERSION=3D 2017-04-09 instead. Probably could use an update to the newest version too. XPKGNAMEPREFIX=3D naken_asm- This will result in a package name of naken_asm-naken_asm which makes little sense. X#RUN_DEPENDS=3D libreadline.so:devel/readline Useless (and also wrong) comment. XGNU_CONFIGURE=3D yes Port does not use an autotools generated configure script, so it should be HAS_CONFIGURE instead. configure seems to use bash so it looks like there is a missing BUILD_DEPENDS for it here. X @mkdir -p ${STAGEDIR}${PREFIX} mkdir -p should be ${MKDIR}, but it's also unnecessary here. A stage directory and prefix skeleton is already created from /usr/ports/Templates/BSD.local.dist by the framework. X @cp ${WRKSRC}/naken_asm ${STAGEDIR}${PREFIX}/bin/ Never use cp in do-install. Use one of the INSTALL_* macros, here ${INSTALL_PROGRAM}. It'll make sure that the binaries have the right permissions and that they are stripped. XWWW: http://www.mikekohn.net/micro/naken_asm.php X X Superfluous new lines at the end of pkg-descr. X/usr/local/bin/naken_asm X/usr/local/bin/naken_util A two line pkg-plist should just be folded directly into PLIST_FILES in the Makefile. Also drop the /usr/local/ prefix here. PREFIX can be overridden by users and it's implied if the path is relative. Other issues: - Missing LICENSE and LICENSE_FILE - The port does not respect CFLAGS and LDFLAGS as set by the framework/users https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html --=20 You are receiving this mail because: You are the assignee for the bug.=