From owner-freebsd-ports-bugs@freebsd.org Sun Jun 9 18:57:26 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36DE915CD968 for ; Sun, 9 Jun 2019 18:57:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BC9FF8293E for ; Sun, 9 Jun 2019 18:57:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 7BBBB15CD967; Sun, 9 Jun 2019 18:57:25 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A15115CD966 for ; Sun, 9 Jun 2019 18:57:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E87C68293C for ; Sun, 9 Jun 2019 18:57:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 295611390 for ; Sun, 9 Jun 2019 18:57:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x59IvOuG063934 for ; Sun, 9 Jun 2019 18:57:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x59IvOtI063928 for ports-bugs@FreeBSD.org; Sun, 9 Jun 2019 18:57:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 238424] net/kafka: fix rc script Date: Sun, 09 Jun 2019 18:57:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dmitry.wagin@ya.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jun 2019 18:57:26 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238424 --- Comment #3 from Dmitry Wagin --- (In reply to timp87 from comment #2) 1. fixed pidfile/piddir manipulation before patch when kafka_pidfile=3D"/var/run/kafka.pid", the following occur= red: chown kafka:kafka /var/run 2. added support daemon supervise and restart functionality > man daemon -r Supervise and restart the program after a one-second delay if it has been terminated. -R restart_delay_seconds Supervise and restart the program after the specif= ied delay if it has been terminated. -P supervisor_pidfile Write the ID of the daemon process into the supervisor_pidfile The -P option is useful combined with the -r option as supervisor_pidfile contains the ID of the supervisor not the child. This is especially import= ant if you use -r in an rc script as the -p option will give you the child's ID= to signal when you attempt to stop the service, causing daemon to restart the child. 3. added requirement for log directory required_dirs=3D"${kafka_log_dir}" as a replacement [ -d "$kafka_log_dir" ] || mkdir -p "$kafka_log_dir" 4. fixed title for the daemon process I think it is a good idea to always set the process name (-t ${name}), not = only when kafka_syslog_output_enable=3D"YES" --=20 You are receiving this mail because: You are the assignee for the bug.=