From owner-freebsd-ports@FreeBSD.ORG  Mon Aug  4 14:59:54 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6DDDA37B401
	for <ports@FreeBSD.org>; Mon,  4 Aug 2003 14:59:54 -0700 (PDT)
Received: from SMTP1.sdccd.cc.ca.us (smtp1.sdccd.cc.ca.us [209.129.16.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E223643FA3
	for <ports@FreeBSD.org>; Mon,  4 Aug 2003 14:59:53 -0700 (PDT)
	(envelope-from efortenb@sdccd.cc.ca.us)
Received: from ntxdistrict.sdccd.cc.ca.us ([10.1.100.1])
	by SMTP1.sdccd.cc.ca.us (8.12.9/8.12.9) with ESMTP id h74LxW3S077692;
	Mon, 4 Aug 2003 14:59:33 -0700 (PDT)
Received: by ntxdistrict.sdccd.cc.ca.us with Internet Mail Service
	(5.5.2655.55)	id <PNWSYCL9>; Mon, 4 Aug 2003 14:59:51 -0700
Message-ID: <BBDEEDD2EB67D311A0240008C74B93453A960D@ntxmidcity.sdccd.cc.ca.us>
From: Erin Fortenberry <efortenb@sdccd.cc.ca.us>
To: "'ports@FreeBSD.org'" <ports@FreeBSD.org>
Date: Mon, 4 Aug 2003 14:59:41 -0700 
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2655.55)
Content-Type: text/plain
cc: "'ports@FreeBSD.org'" <ports@FreeBSD.org>
Subject: FreeBSD Port: apache13-modssl-1.3.28+2.8.15
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2003 21:59:54 -0000

I have been having zombie problems with apache/suexec.

>From this bug;

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21737


I tested the patch;

http://nagoya.apache.org/bugzilla/showattachment.cgi?attach_id=7407

I know this is not an "official" patch, but it worked for me.

If anyone else has been having problems try it out.


The patch I installed ended up looking like this;


--- src/main/alloc.c.orig	Sun Jul 20 14:30:30 2003
+++ src/main/alloc.c	Sun Jul 20 14:33:50 2003
@@ -2860,7 +2860,14 @@
 	    || (p->kill_how == kill_only_once)) {
 	    /* Subprocess may be dead already.  Only need the timeout if
not. */
 	    if (ap_os_kill(p->pid, SIGTERM) == -1) {
-                p->kill_how = kill_never;
+		/* If the kill failed, find out why.  If the process does 
+		   not exist then we do not need to kill it.  */
+		if (errno == ESRCH) {			
+	                p->kill_how = kill_never;
+		}
+		else {
+			need_timeout = 1;
+		} 
             }
             else {
 		need_timeout = 1;