From owner-svn-ports-all@freebsd.org  Fri Jun  3 07:21:42 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F5E1B68C77;
 Fri,  3 Jun 2016 07:21:42 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from critical.ch (critical.ch [IPv6:2a01:4f8:c17:de4::1:1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mx.critical.ch",
 Issuer "StartCom Class 1 DV Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E348B1252;
 Fri,  3 Jun 2016 07:21:41 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from wiggles.local (dynamic.wline.6rd.res.cust.swisscom.ch
 [IPv6:2a02:1205:34c0:65e0:dad3:85ff:fe79:dd2] (may be forged))
 (authenticated bits=0)
 by critical.ch (8.15.2/8.15.2/critical-1.0) with ESMTPA id u537LUwL069174;
 Fri, 3 Jun 2016 09:21:31 +0200 (CEST)
 (envelope-from ehaupt@FreeBSD.org)
Date: Fri, 3 Jun 2016 09:21:25 +0200
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r416270 - head/net/rsync
Message-Id: <20160603092125.2476cdcae34209c83d62ae91@FreeBSD.org>
In-Reply-To: <8D42CA4C-75EC-4402-BA69-DF20E3F62462@adamw.org>
References: <201606020735.u527ZoAj066577@repo.freebsd.org>
 <8D42CA4C-75EC-4402-BA69-DF20E3F62462@adamw.org>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.29; amd64-portbld-freebsd10.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jun 2016 07:21:42 -0000

Adam Weinberger <adamw@adamw.org> wrote:
> > On 2 Jun, 2016, at 1:35, Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
> > 
> > Author: ehaupt
> > Date: Thu Jun  2 07:35:49 2016
> > New Revision: 416270
> > URL: https://svnweb.freebsd.org/changeset/ports/416270
> > 
> > Log:
> >  Fix the logic of the POPT_PORT option.
> > 
> >  - POPT_CONFIGURE_WITH should actually be POPT_PORT_CONFIGURE_WITH
> >  - The whole ^POPT block logic is reversing the logic
> >  - Bump PORTREVISION since we have a change of dependencie
> > 
> >  PR:		209837 (based on)
> >  Submitted by:	Martin Birgmeier <la5lbtyi@aon.at>
> >  MFH:		2016Q2
> > 
> > -POPT_PORT_LIB_DEPENDS=	libpopt.so:devel/popt
> > -POPT_PORT_CPPFLAGS=	-I${LOCALBASE}/include
> > -POPT_PORT_LDFLAGS=	-L${LOCALBASE}/lib
> > -POPT_CONFIGURE_WITH=	included-popt
> > +POPT_PORT_LIB_DEPENDS_OFF=	libpopt.so:devel/popt
> > +POPT_PORT_CPPFLAGS_OFF=	-I${LOCALBASE}/include
> > +POPT_PORT_LDFLAGS_OFF=	-L${LOCALBASE}/lib
> > +
> > +POPT_PORT_CONFIGURE_WITH=	included-popt
> 
> Wait, now you've made it backwards.
> 
> Now:
> "Use popt from devel/popt"
> ON = use bundled popt
> OFF = use popt from devel/popt
> 
> Those need to be switched!

Of course you're right.

Emanuel