From owner-freebsd-hackers  Tue Nov 26  8:41:18 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A6E9A37B406
	for <freebsd-hackers@freebsd.org>; Tue, 26 Nov 2002 08:41:16 -0800 (PST)
Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 37B6343E4A
	for <freebsd-hackers@freebsd.org>; Tue, 26 Nov 2002 08:41:16 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 25298 invoked from network); 26 Nov 2002 16:41:19 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <freebsd-hackers@freebsd.org>; 26 Nov 2002 16:41:19 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gAQGfEuH013047;
	Tue, 26 Nov 2002 11:41:15 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20021126114120.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20021126111427.GB1063@gothis.peppernet.se>
Date: Tue, 26 Nov 2002 11:41:20 -0500 (EST)
From: John Baldwin <jhb@FreeBSD.org>
To: Alexander Funcke <funcke@nano-system.com>
Subject: RE: Correct way to get hold of a isab
Cc: freebsd-hackers@freebsd.org
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG


On 26-Nov-2002 Alexander Funcke wrote:
> Hi,
> 
> 
> I've written a GPIO driver for the National Geode SCx200 processors.
> While I was developing I added the following line in isab_match()
> (sys/pci/pcisupport.c) so it wouldn't be identified as a isa-bridge.
> 
> 
> isab_match(device_t dev)
> {
>       switch(pci_get_devid(dev)) {
> 
>       .
>       .
>       .
> 
>               /* National Geode SCx200's ISA and GPIO/LPC bridge,
>                  needs to be free so we can claim it later from
>                  the GPIO-driver.  */
> 
>               case 0x0500100b:
>                       return(NULL);
>               }
>       
>       .
>       .
>       .
> }
> 
> This do work, but I guess this isn't the correct way, how should it 
> be done?

Does this device have a class of PCIC_BRIDGE and subclass of PCIS_BRIDGE_ISA?
(class of 0x0601zz where zz is any value).  If so it is claiming to be a
PCI-ISA bridge.  If this device is not a PCI-ISA bridge, then it shouldn't
claim to be one.  If it is a PCI-ISA bridge then you do need to use that
kind of hack for now.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message