From owner-svn-src-head@FreeBSD.ORG Fri May 1 13:51:39 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1EF29672; Fri, 1 May 2015 13:51:39 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 85EB319C1; Fri, 1 May 2015 13:51:37 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t41DpYZ1027917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 1 May 2015 16:51:34 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t41DpYYm027916; Fri, 1 May 2015 16:51:34 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 1 May 2015 16:51:34 +0300 From: Gleb Smirnoff To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282280 - in head/sys/dev: e1000 ixgbe ixl Message-ID: <20150501135134.GC546@FreeBSD.org> References: <201504301823.t3UINd74073186@svn.freebsd.org> <20150430232736.GB546@FreeBSD.org> <1998053.shmPH6saZj@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1998053.shmPH6saZj@ralph.baldwin.cx> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2015 13:51:39 -0000 On Fri, May 01, 2015 at 09:11:54AM -0400, John Baldwin wrote: J> > On Thu, Apr 30, 2015 at 06:23:39PM +0000, John Baldwin wrote: J> > J> Author: jhb J> > J> Date: Thu Apr 30 18:23:38 2015 J> > J> New Revision: 282280 J> > J> URL: https://svnweb.freebsd.org/changeset/base/282280 J> > J> J> > J> Log: J> > J> Various fixes to the stats in igb(4), ixgbe(4), and ixl(4). J> > J> - Use hardware counters for ifnet stats in igb(4) when possible. This J> > J> ensures these stats include packets that bypass the regular stack via J> > J> netmap. J> > J> - Don't derefence values off the end of the igb(4) VF stats structure. J> > J> Instead, add a dedicated if_get_counter method for igb(4) VF interfaces. J> > J> - Report missed packets on igb(4) as input queue drops rather than an J> > J> input error. J> > J> - Report bug_ring drop counts as output queue drops for igb(4) and ixgbe(4). J> > J> - Export the buf_ring drop stats for individual rings via sysctl on J> > J> ixgbe(4).^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ J> > ^^^^^^^^^ J> > J> > While you are here, let me remind you about this plan: J> > J> > https://lists.freebsd.org/pipermail/svn-src-head/2014-October/063575.html J> > J> > We can prototype the API to userland now, write down a utility that uses J> > it, or add the functionality to an existing utility. And start with Intel J> > drivers, that seem to be most interested in extra stats. J> J> So the importaing thing here is that if_get_counter() is still doing J> per-ifnet stats. The stat you underlined above is per-queue instead. J> We well need more explicitly knowledge of queues outside of drivers J> and in the stack itself to support a generic framework for per-queue J> stats. This depends on how generic we want the API to be. Of course, we can add an extra argument to if_get_counter(). However, if we don't expect the number of queues to exceed a reasonable number of 255 :), we can fit the functionality into existing API. We can keep the queue number in the highest 8 bits of the ift_counter parameter. #define IFCOUNTER_MASK 0x00ffffff #define IFCOUNTER_QUEUE(c) ((c) >> 24) -- Totus tuus, Glebius.