From owner-freebsd-net@FreeBSD.ORG  Sat Aug  6 12:16:25 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CC37116A41F
	for <freebsd-net@freebsd.org>; Sat,  6 Aug 2005 12:16:25 +0000 (GMT)
	(envelope-from bms@spc.org)
Received: from arginine.spc.org (arginine.spc.org [83.167.185.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0CFEC43D53
	for <freebsd-net@freebsd.org>; Sat,  6 Aug 2005 12:16:23 +0000 (GMT)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 2234665640; Sat,  6 Aug 2005 13:16:16 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
	by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id 87500-01-4; Sat,  6 Aug 2005 13:16:15 +0100 (BST)
Received: from empiric.dek.spc.org (213-152-59-152.dsl.eclipse.net.uk
	[213.152.59.152])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 39FE665641; Sat,  6 Aug 2005 13:16:11 +0100 (BST)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id 866F86ABC; Sat,  6 Aug 2005 13:15:04 +0100 (BST)
Date: Sat, 6 Aug 2005 13:15:04 +0100
From: Bruce M Simpson <bms@spc.org>
To: Gordon Bergling <gbergling@0xfce3.net>
Message-ID: <20050806121504.GC740@empiric.icir.org>
Mail-Followup-To: Gordon Bergling <gbergling@0xfce3.net>,
	freebsd-net@freebsd.org
References: <42F4A261.9060207@0xfce3.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42F4A261.9060207@0xfce3.net>
Cc: freebsd-net@freebsd.org
Subject: Re: [RFC] Port of DfBSDs new IP Checksum Code
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Aug 2005 12:16:25 -0000

Hi,

On Sat, Aug 06, 2005 at 01:43:29PM +0200, Gordon Bergling wrote:
> I have ported the new IP Checksum Code from DragonflyBSD to FreeBSD.
> I have a patch available at
> http://generic.0xfce3.net/freebsd/ipchecksum/20050805-ipchecksum.patch

There are inline i386 instructions in a machine-independent header; is this
intentional? Also the asm_ones32() code seems to exist only for i386.

Without support for other platforms, and some cleanup, I don't think that
the patch can be committed as is, sadly.

I do like the general idea of rewriting in_cksum() to take advantage of
branch prediction logic in modern microprocessors, however.

Regards,
BMS