Date: Sat, 6 Aug 2005 13:15:04 +0100 From: Bruce M Simpson <bms@spc.org> To: Gordon Bergling <gbergling@0xfce3.net> Cc: freebsd-net@freebsd.org Subject: Re: [RFC] Port of DfBSDs new IP Checksum Code Message-ID: <20050806121504.GC740@empiric.icir.org> In-Reply-To: <42F4A261.9060207@0xfce3.net> References: <42F4A261.9060207@0xfce3.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Sat, Aug 06, 2005 at 01:43:29PM +0200, Gordon Bergling wrote: > I have ported the new IP Checksum Code from DragonflyBSD to FreeBSD. > I have a patch available at > http://generic.0xfce3.net/freebsd/ipchecksum/20050805-ipchecksum.patch There are inline i386 instructions in a machine-independent header; is this intentional? Also the asm_ones32() code seems to exist only for i386. Without support for other platforms, and some cleanup, I don't think that the patch can be committed as is, sadly. I do like the general idea of rewriting in_cksum() to take advantage of branch prediction logic in modern microprocessors, however. Regards, BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050806121504.GC740>