Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Apr 2016 18:57:30 +0000 (UTC)
From:      Luiz Otavio O Souza <loos@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r297985 - head/sys/netinet
Message-ID:  <201604141857.u3EIvUGC098322@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: loos
Date: Thu Apr 14 18:57:30 2016
New Revision: 297985
URL: https://svnweb.freebsd.org/changeset/base/297985

Log:
  Do not overwrite the dchg variable.
  
  It does not cause any real issues because the variable is overwritten
  only when the packet is forwarded (and the variable is not used anymore).
  
  Obtained from:	pfSense
  MFC after:	2 weeks
  Sponsored by:	Rubicon Communications (Netgate)

Modified:
  head/sys/netinet/ip_input.c

Modified: head/sys/netinet/ip_input.c
==============================================================================
--- head/sys/netinet/ip_input.c	Thu Apr 14 18:37:40 2016	(r297984)
+++ head/sys/netinet/ip_input.c	Thu Apr 14 18:57:30 2016	(r297985)
@@ -571,8 +571,7 @@ tooshort:
 		goto ours;
 	}
 	if (m->m_flags & M_IP_NEXTHOP) {
-		dchg = (m_tag_find(m, PACKET_TAG_IPFORWARD, NULL) != NULL);
-		if (dchg != 0) {
+		if (m_tag_find(m, PACKET_TAG_IPFORWARD, NULL) != NULL) {
 			/*
 			 * Directly ship the packet on.  This allows
 			 * forwarding packets originally destined to us



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604141857.u3EIvUGC098322>