From owner-svn-src-all@FreeBSD.ORG Fri Jan 10 10:39:02 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56A46CC5; Fri, 10 Jan 2014 10:39:02 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 289AE1E8B; Fri, 10 Jan 2014 10:39:02 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id s0AAd2qQ048084; Fri, 10 Jan 2014 10:39:02 GMT (envelope-from jmmv@svn.freebsd.org) Received: (from jmmv@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id s0AAd1bE048076; Fri, 10 Jan 2014 10:39:01 GMT (envelope-from jmmv@svn.freebsd.org) Message-Id: <201401101039.s0AAd1bE048076@svn.freebsd.org> From: Julio Merino Date: Fri, 10 Jan 2014 10:39:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r260506 - in head/bin: sh/tests test/tests X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2014 10:39:02 -0000 Author: jmmv Date: Fri Jan 10 10:39:01 2014 New Revision: 260506 URL: http://svnweb.freebsd.org/changeset/base/260506 Log: Run the sh(1) and test(1) tests as unprivileged. One of the tests for test(1) fails and some of the tests for sh(1) are silently bypassed when running as root. To fix these tests and ensure they all run, mark the test programs for sh(1) and test(1) as requiring an unprivileged user. (This should and will be the default in Kyua but isn't yet.) MFC after: 1 week Added: head/bin/sh/tests/Kyuafile (contents, props changed) head/bin/test/tests/Kyuafile (contents, props changed) Modified: head/bin/sh/tests/Makefile head/bin/test/tests/Makefile Added: head/bin/sh/tests/Kyuafile ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/bin/sh/tests/Kyuafile Fri Jan 10 10:39:01 2014 (r260506) @@ -0,0 +1,12 @@ +-- $FreeBSD$ + +syntax(2) + +test_suite("FreeBSD") + +-- Some tests in here are silently not run when the tests are executed as +-- root. Explicitly tell Kyua to drop privileges. +-- +-- TODO(jmmv): Kyua needs to do this by default, not only when explicitly +-- requested. See https://code.google.com/p/kyua/issues/detail?id=6 +tap_test_program{name="legacy_test", required_user="unprivileged"} Modified: head/bin/sh/tests/Makefile ============================================================================== --- head/bin/sh/tests/Makefile Fri Jan 10 10:36:14 2014 (r260505) +++ head/bin/sh/tests/Makefile Fri Jan 10 10:39:01 2014 (r260506) @@ -3,6 +3,7 @@ .include TESTSDIR= ${TESTSBASE}/bin/sh +KYUAFILE= yes TAP_TESTS_SH= legacy_test TAP_TESTS_SH_SED_legacy_test= -e 's,__SH__,/bin/sh,g' Added: head/bin/test/tests/Kyuafile ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/bin/test/tests/Kyuafile Fri Jan 10 10:39:01 2014 (r260506) @@ -0,0 +1,12 @@ +-- $FreeBSD$ + +syntax(2) + +test_suite("FreeBSD") + +-- Some tests in here are silently not run when the tests are executed as +-- root. Explicitly tell Kyua to drop privileges. +-- +-- TODO(jmmv): Kyua needs to do this by default, not only when explicitly +-- requested. See https://code.google.com/p/kyua/issues/detail?id=6 +tap_test_program{name="legacy_test", required_user="unprivileged"} Modified: head/bin/test/tests/Makefile ============================================================================== --- head/bin/test/tests/Makefile Fri Jan 10 10:36:14 2014 (r260505) +++ head/bin/test/tests/Makefile Fri Jan 10 10:39:01 2014 (r260506) @@ -3,6 +3,7 @@ .include TESTSDIR= ${TESTSBASE}/bin/test +KYUAFILE= yes TAP_TESTS_SH= legacy_test