Date: Tue, 28 Feb 2017 22:30:51 -0700 From: Warner Losh <imp@bsdimp.com> To: Hiroki Sato <hrs@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314471 - head/sys/net Message-ID: <CANCZdfrhEGzHAzP8aaO19ByBSH7RaqGoUb1s9%2B8kzd2ARy=Jcg@mail.gmail.com> In-Reply-To: <20170301.141856.1441900213581775162.hrs@allbsd.org> References: <201703010447.v214lM4c026957@repo.freebsd.org> <20170301.141856.1441900213581775162.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 28, 2017 at 10:18 PM, Hiroki Sato <hrs@freebsd.org> wrote: > Warner Losh <imp@FreeBSD.org> wrote > in <201703010447.v214lM4c026957@repo.freebsd.org>: > > im> Author: imp > im> Date: Wed Mar 1 04:47:22 2017 > im> New Revision: 314471 > im> URL: https://svnweb.freebsd.org/changeset/base/314471 > im> > im> Log: > im> Fix VNET - DAD detected duplicate IPv6 address > im> > im> Assign a hopefully unique, locally administered etheraddr. - for > im> epairNa & epairNb > im> > im> Submitted by: Catalin <sslevil@users.noreply.github.com> > im> Pull Request: https://github.com/freebsd/freebsd/pull/92 > > This was discussed in D1858. epairNa and epairNb never have the same > L2 addr because eaddr[5] is unique. If the goal of this change is to > prevent a conflict of L2 addrs with epairNs created in another vnet > jail on the same system or on the same network, eaddr[5] of epairNa > (around l.839) must also be randomized at least. > > While I am still for a deterministic value because changing the L2 > addr every time when rebooting a vnet jail is annoying, but if we use > some random numbers for the vendor bits, I think eaddr[2] should be > initialized in the same way. It's clear the consensus there was 'no go' and I don't wish to override it. I didn't know about that, so I'll revert. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrhEGzHAzP8aaO19ByBSH7RaqGoUb1s9%2B8kzd2ARy=Jcg>