From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 19 09:40:02 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 380B51065672 for ; Sat, 19 Jun 2010 09:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EB63D8FC1B for ; Sat, 19 Jun 2010 09:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o5J9e1pd069733 for ; Sat, 19 Jun 2010 09:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o5J9e14v069732; Sat, 19 Jun 2010 09:40:01 GMT (envelope-from gnats) Resent-Date: Sat, 19 Jun 2010 09:40:01 GMT Resent-Message-Id: <201006190940.o5J9e14v069732@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthew Seaman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6691B106564A for ; Sat, 19 Jun 2010 09:30:03 +0000 (UTC) (envelope-from m.seaman@infracaninophile.co.uk) Received: from smtp.infracaninophile.co.uk (gate6.infracaninophile.co.uk [IPv6:2001:8b0:151:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id C95A08FC0A for ; Sat, 19 Jun 2010 09:30:02 +0000 (UTC) Received: from lucid-nonsense.infracaninophile.co.uk (localhost [IPv6:::1]) by smtp.infracaninophile.co.uk (8.14.4/8.14.4) with ESMTP id o5J9Txjl084750 for ; Sat, 19 Jun 2010 10:29:59 +0100 (BST) (envelope-from matthew@lucid-nonsense.infracaninophile.co.uk) Received: (from matthew@localhost) by lucid-nonsense.infracaninophile.co.uk (8.14.4/8.14.4/Submit) id o5J9TxGY084749; Sat, 19 Jun 2010 10:29:59 +0100 (BST) (envelope-from matthew) Message-Id: <201006190929.o5J9TxGY084749@lucid-nonsense.infracaninophile.co.uk> Date: Sat, 19 Jun 2010 10:29:59 +0100 (BST) From: Matthew Seaman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/147993: [patch] mail/dkim-milter -- plist problems X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Seaman List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2010 09:40:02 -0000 >Number: 147993 >Category: ports >Synopsis: [patch] mail/dkim-milter -- plist problems >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jun 19 09:40:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Matthew Seaman >Release: FreeBSD 8.1-PRERELEASE amd64 >Organization: Infracaninophile >Environment: System: FreeBSD lucid-nonsense.infracaninophile.co.uk 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #4: Fri May 28 11:09:30 BST 2010 root@lucid-nonsense.infracaninophile.co.uk:/usr/obj/usr/src/sys/LUCID-NONSENSE amd64 >Description: I'm getting a plist error for mail/dkim-milter with the following options set in /etc/make.conf: .if ${.CURDIR:M*/mail/dkim-milter} WITH_LIBDKIM_INSTALL= yes WITH_LIBDKIM_SHARED= yes WITH_VERIFY_DOMAINKEYS= yes WITH_STATS= yes WITH_DNS_UPGRADE= yes .endif The error is this: lucid-nonsense:~:% pkg_create -b dkim-milter-2.8.3_1 tar: lib/libar.a: Cannot stat: No such file or directory tar: Error exit delayed from previous errors. pkg_create: make_dist: tar command failed with code 256 ie. lib/libar appears in the plist, but it isn't installed by the port. Defining WITHOUT_ARLIB=yes seemed to fix the problem -- given this clue, after poring over the Makefile a bit, I think there's a logic mistake: bld_USE_ARLIB is being removed from the site.cfg when WITHOUT_ARLIB is *undefined* -- which implies that WITH_ARLIB is defined. This results in a correct plist with or without WITHOUT_ARLIB being defined. >How-To-Repeat: >Fix: --- dkim-milter.diff begins here --- ? work Index: Makefile =================================================================== RCS file: /home/ncvs/ports/mail/dkim-milter/Makefile,v retrieving revision 1.64 diff -u -u -r1.64 Makefile --- Makefile 28 Mar 2010 21:45:53 -0000 1.64 +++ Makefile 19 Jun 2010 09:19:23 -0000 @@ -209,7 +209,7 @@ -e '\|bld_USE_UNBOUND.*true|s/^dnl //g' .else SITE_SUB+= -e 's|%%UNBOUND%%|dnl |g' -.if !defined(WITHOUT_ARLIB) +.if !defined(WITH_ARLIB) SITE_SUB+= -e '\|bld_USE_ARLIB.*true|s/^dnl //g' .endif .endif --- dkim-milter.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: