From owner-svn-src-head@freebsd.org Fri Nov 13 21:47:55 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 764BDA2E451 for ; Fri, 13 Nov 2015 21:47:55 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pa0-x236.google.com (mail-pa0-x236.google.com [IPv6:2607:f8b0:400e:c03::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 36D711761 for ; Fri, 13 Nov 2015 21:47:55 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by padhx2 with SMTP id hx2so111686961pad.1 for ; Fri, 13 Nov 2015 13:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=Xrh6ujRVWsjbxqUpvnicdqW/M26eudKwY050lTEK5sI=; b=ZDPEE4kLy+S8HYaKlN8Y7EdDBRgrYEIYnPeEoLBlwIZAxG3+v+Vf5IgKeAevthI3zD Q3oEcKced1kaOUsbqocsgt6AnsufVBvTgII0plPmNg7DRZn8CS6Ly0siQ69TBv6x8Qpp 508A8MdykiXHSd69u+ZEV7u08U0RB7CGe1riI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=Xrh6ujRVWsjbxqUpvnicdqW/M26eudKwY050lTEK5sI=; b=QWvLYs0fg9u25339ErAvGXKSsRs6l+1WOCm9Yz3rDLwV55odndB1NcbGzHxRRtAUri MN+rw41vHXx9qO5efZGE0DYqHvjtKrXGCnhJTEiElM9zxKOMSp1wVmfeO04dYPyGISG+ sBrN/gnM2D63tPT2CrclQMvGNRakCF1+D1JE9jt5qwWN5tMmoazJtkgOoN+4b5Mx1YSb 04Gfiq2lq/g/DU6jmghO+5TNU+h1HHnUqV/8NbPUEofxHMYz1nViGLFdAuMgJ7tcivOp sTj3yNddpTwsuZ+NBIhntEJv1pXj/4Wp64gg2ic3GNzd/tFiRRSGLhbpewxuqXXjZDB/ sOkA== X-Gm-Message-State: ALoCoQmZlnzxI/rEguEn6iTbimunn7UNJAnH6WmxK/1LgGMLBM+bYTeeGCevnzE5I+g5T5E2hVJb X-Received: by 10.67.30.168 with SMTP id kf8mr35875370pad.106.1447451274729; Fri, 13 Nov 2015 13:47:54 -0800 (PST) Received: from ip-192-168-70-10.us-west-2.compute.internal ([69.53.245.107]) by smtp.gmail.com with ESMTPSA id cn4sm22167889pbc.94.2015.11.13.13.47.50 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Nov 2015 13:47:53 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys From: Randall Stewart In-Reply-To: <56465991.5090906@FreeBSD.org> Date: Fri, 13 Nov 2015 16:47:53 -0500 Cc: "Alexander V. Chernikov" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org Message-Id: References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <56465003.8070709@FreeBSD.org> <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> <56465991.5090906@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 21:47:55 -0000 On Nov 13, 2015, at 4:43 PM, Bryan Drewery wrote: > On 11/13/2015 1:24 PM, Randall Stewart wrote: >> Looking at the patch, we need a define of your >>=20 >> _callout_stop_safe >>=20 >> and we need to switch >>=20 >> callout_stop()=92s define to use the new _callout_stop_safe() >=20 > For both cases, there would be no reason to have new code call my > wrapper. The defines in my patch are fine for new code. The "new" > _callout_stop_safe function is just for existing modules. >=20 > I think the historical consensus is to not commit my patch though as > people should recompile their modules when the kernel is updated, = before > rebooting into the new kernel even. I did (as Han=92s suggested) bump the FreeBSD version number.. So maybe thats good enough. R >=20 >=20 >>=20 >> R >> On Nov 13, 2015, at 4:20 PM, Randall Stewart > > wrote: >>=20 >>> No alexander=92s panic=92s are because the >>> LLREF >>> is done if (callout_stop()) >>>=20 >>> But now if it was not running -1 is returned.. >>>=20 >>> Try the patch I just sent.. >>>=20 >>> R >>> On Nov 13, 2015, at 4:02 PM, Bryan Drewery >> > wrote: >>>=20 >>>> On 11/13/2015 1:00 PM, Randall Stewart wrote: >>>>> Bryan: >>>>>=20 >>>>> This looks like a decent thing to do.. >>>>>=20 >>>>> Still wondering why changing the callout.h header file would not >>>>> have caused >>>>> things to recompile to pick up the new argument.. >>>>>=20 >>>>> We can do it this way though it looks fine. >>>>>=20 >>>>> You want to commit it or I? >>>>=20 >>>> Well your change is totally safe for compiling. It's just not KBI >>>> backwards compat for older modules. This is not typically a problem = but >>>> I think in this case it is worth doing to avoid random data coming = into >>>> the 'drain' argument if loading an older module. >>>>=20 >>>> I'll do a test build and commit it. Perhaps this is what was = leading to >>>> Alexander's panics. >>>>=20 >>>> I haven't analyzed the return value issue at all. >>>>=20 >>>>=20 >=20 >=20 > --=20 > Regards, > Bryan Drewery >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952