From owner-svn-src-head@freebsd.org Fri Jan 26 05:02:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 452B0EC09C9; Fri, 26 Jan 2018 05:02:53 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AD0D68314D; Fri, 26 Jan 2018 05:02:52 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-wm0-x22c.google.com with SMTP id g1so18589304wmg.2; Thu, 25 Jan 2018 21:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y+CzTJPY77E7TEExA5GTcfWziuyUv0PPi5c3Ncr7aAw=; b=B4WkODkYgQ7VBxQhrxS+yfKwT+PUqeiYrvMir0m6qAb1xfJUzRZM27RxFByxee3wQ3 UtvMP6ZgoIe/P0KyEBJZ3GGwsMTfGjW5BZdvRdomy6tlyGGjsd+xRKLzMOzzjEA0BYU+ cwa6B+eMl8K7V/JsMlxU6O8PRuBPwFuxT1J7zJVsmMDrYmLr++Ov2XU5BVc8XSs2edz1 IIevN6I7zJpV0XhWKKa9Ycq4m6GN3Wo7l96RYjXCfNqaJHGoHRnCOPK94+w7l9b3ada2 pASyN8MdnceBWWLyh4E9ESgbyQgQOfxGyvVOJTZygFO9uz4k/XlRfi7WsseT26HIs/oP QRqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y+CzTJPY77E7TEExA5GTcfWziuyUv0PPi5c3Ncr7aAw=; b=R6YlC12E+aZjU9S7ROGcxH7Kgc91AUARaqjvEJ//R2Mt0oz613UMmTwZ/e1P+Ndw8w qKqnLjHkBXy+GePr5QupgosU/VVjmr0r4GWA0wDiEW5klspUzjuXSCIfZ15DTCqTrlr+ ReRp+PWZqWummvSuc7KlblSbR+h/W7ebd9aHWBYdO3f/TJ4hm+45WLbxdyp0cKdeQXA3 SV+6WGZ3NTErv5tUUHASni3qi809WqPTsSQDXdPxlivGAA5EjAu/O/OWaDfEhj31r5c0 AL7XGmiK7VXEOdzG6RYauMdUAI0x5scuZPKfYYgerMDO/V6a6qEKeDxs+b1YP+brzcqB BSOA== X-Gm-Message-State: AKwxytcZW5ZIZI4OKGz6QAnaQCx5nif2bEu0DqOqdg82Kca+x0zUks0O /83YjCsm9dN9sS1UhTdHF6OawwZdsguF+W7PfvyTgQ== X-Google-Smtp-Source: AH8x227rfenIF0zt482KyIuRIV3g2SvLFmpQkAlrO/NbgCglwyq9RI0nf3DpcGIRVAdk1QPrcw8c19SRz1CnuuGjq0I= X-Received: by 10.28.144.197 with SMTP id s188mr10113737wmd.51.1516942971499; Thu, 25 Jan 2018 21:02:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.170.69 with HTTP; Thu, 25 Jan 2018 21:02:51 -0800 (PST) In-Reply-To: References: <201801260440.w0Q4efhg008105@repo.freebsd.org> From: Matt Joras Date: Thu, 25 Jan 2018 21:02:51 -0800 Message-ID: Subject: Re: svn commit: r328430 - head/sbin/devd To: Warner Losh Cc: Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 05:02:53 -0000 On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: > > > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: >> >> Author: eadler >> Date: Fri Jan 26 04:40:41 2018 >> New Revision: 328430 >> URL: https://svnweb.freebsd.org/changeset/base/328430 >> >> Log: >> devd: minor nits >> >> - mark usage as noreturn >> - config does not need a virtual destructor > > > Everything needs a virtual destructor... Please back that part of this > out... > > Warner Needs? If there's not inheritance there's no _need_ to do it, and it's arguably superfluous. That being said it's also an arguably superfluous change to remove it. Matt