From owner-svn-src-all@FreeBSD.ORG Fri Aug 9 19:58:27 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTP id C59B16B;
Fri, 9 Aug 2013 19:58:27 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id 9ADEB2E88;
Fri, 9 Aug 2013 19:58:27 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
by bigwig.baldwin.cx (Postfix) with ESMTPSA id 62210B939;
Fri, 9 Aug 2013 15:58:26 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "David E. O'Brien" <obrien@freebsd.org>
Subject: Re: svn commit: r254150 - head/sys/vm
Date: Fri, 9 Aug 2013 15:56:47 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; )
References: <201308091643.r79GhoWx023884@svn.freebsd.org>
In-Reply-To: <201308091643.r79GhoWx023884@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201308091556.47535.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
(bigwig.baldwin.cx); Fri, 09 Aug 2013 15:58:26 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for "
user" and " projects" \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Aug 2013 19:58:27 -0000
On Friday, August 09, 2013 12:43:50 pm David E. O'Brien wrote:
> Author: obrien
> Date: Fri Aug 9 16:43:50 2013
> New Revision: 254150
> URL: http://svnweb.freebsd.org/changeset/base/254150
>
> Log:
> Add missing 'VPO_BUSY' from r254141 to fix kernel build break.
>
> Modified:
> head/sys/vm/vm_page.h
This can't possibly be correct as r254138 just removed this flag. If it isn't
obvious how to fix the uses added back in r254141, then r254141 should be
reverted instead.
Hmm, looking at the relevant bits of r254141, it doesn't look obvious:
+ /* Detach the old page from the resident tailq. */
+ TAILQ_REMOVE(&object->memq, mold, listq);
+ vm_page_lock(mold);
+ if (mold->oflags & VPO_BUSY) {
+ mold->oflags &= ~VPO_BUSY;
+ vm_page_flash(mold);
+ }
Since nothing is setting this flag, this can't possibly work correctly
currently. I wouldn't boot a top-of-tree kernel right now. :(
--
John Baldwin