From nobody Tue Jul 28 23:28:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8s9H3mnjz6nSqJ for ; Tue, 28 Jul 2026 23:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8s9H3DwGz3hkn for ; Tue, 28 Jul 2026 23:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785281331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KqO5GCSWxZteC/IYLltAU9NJY5h1p9mqI31rTPlHu/o=; b=wRiSmumM4exeln9KPbZY4HuG4/WOo7+8NVIfNSqAV0efObmxaHOcez+tOE58l6aKDo16kf Gq6XS3ldxhY4QOG/zwgw+uOk2cVuXm97t8ti813/Zn6wD69bP6TJ+7iUd6bUEaPwjUI9qO Uju8x7A69cDkN0EcAykIqxic6P1/chJkFPxjJ3hzzPdibx2JC17Hr1mTskuHAmFQnoyzEc hz3Rg+tPRk/QiD+c6ii3tEielFuYUgUDFSizxijXWG+1xXIlqygq15uAsRG0rChXE7gTAT A53iwSE4JOTj0gPU7J5+jObrMFukyXAxQVBGMFtn+pSSYMTGyYL4KlrZqCxY7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785281331; a=rsa-sha256; cv=none; b=HyoHc4X22AZSL1tis2wHVUEIPC96C4qhLTnDxDfXfgkKawk2d8tdkwfQicrautyEOVbKja gGbyk08DfzLWnnOWe3Z1C9Qd7F82aIAhCYzUuu/zjk5g9hkYVSEDITQuSMrhBo08Nozunt xyYjdWNDP1RxGFfSx4gOqE91uL61iS3NilVwyATG+wC2sk7DzS18dJvA0EpRcQlvbHc5d+ D6scqgzC3mk4GuCLpjbzauyyZ+Qz+KtabF1vSBi4SyGaL3t56ae5vwK9Fa91ANAxd9m6Xh zeqDymbSRiL6/RJWpL8EsyReMezPW9Fkmd9Mk4hPrU/y8UeXshwPFIKwTslgKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785281331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KqO5GCSWxZteC/IYLltAU9NJY5h1p9mqI31rTPlHu/o=; b=GA3rGxy0xKBDB/cHYd3JD2ykMXVBKaLN2QYHVlch3+S5MHCPEgJQSmYfAS2+Z295gyvRqb 1a/1o52t3gAgxezEA/Ki1kcLR7viY3ne/MGmZqfwT9qZxbhy+gQxvLvVq5hsyttKlDsfsX 0zB5j3gWNGlYQe84ugRZyr4roAd+heq/BBHoUnBeTcdDGBv8oSHOYAzl8+c2dAa4Qqb1la IAD7s9SJPinf4Yj2uYX+psADafON2ykh50fBDS9ov0uy5jpyMr+obmTfKrICrluX7Zscrb wf463cdKaPQqLiKOCP4z91AhagQmmoiLis2P0NB3Qvqkr+2EtNCUW9aM1EnT3Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h8s9H2GrHz11YG for ; Tue, 28 Jul 2026 23:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34430 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Jul 2026 23:28:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 954098103ee2 - main - nvme: Add quirk for broken namespace-change log List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 954098103ee287f39ecbf5d3144bcdfd16e7c41d Auto-Submitted: auto-generated Date: Tue, 28 Jul 2026 23:28:51 +0000 Message-Id: <6a693b33.34430.62eb40e8@gitrepo.freebsd.org> The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=954098103ee287f39ecbf5d3144bcdfd16e7c41d commit 954098103ee287f39ecbf5d3144bcdfd16e7c41d Author: Colin Percival AuthorDate: 2026-07-14 17:41:03 +0000 Commit: Colin Percival CommitDate: 2026-07-28 23:28:36 +0000 nvme: Add quirk for broken namespace-change log Add a QUIRK_EMPTY_NAMESPACE_CHANGED_LOG quirk which indicates that the nvme controller may not properly populate the namespace-changed log page. If we receive a NVME_LOG_CHANGED_NAMESPACE page for a device with this quirk and the page is empty, probe all of the namespaces rather than none of them. Reviewed by: imp MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D58231 --- sys/dev/nvme/nvme_ctrlr.c | 5 +++++ sys/dev/nvme/nvme_private.h | 1 + 2 files changed, 6 insertions(+) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index ee61632cf9bb..4b96966114fe 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -1308,6 +1308,11 @@ nvme_ctrlr_aer_task(void *arg, int pending) for (int j = 0; j < n_children; j++) NVME_NS_CHANGED(children[j], nsl->ns[i]); } + if (nsl->ns[0] == 0 && ctrlr->quirks & QUIRK_EMPTY_NAMESPACE_CHANGED_LOG) { + for (int i = 0; i < min(ctrlr->cdata.nn, NVME_MAX_NAMESPACES); i++) + for (int j = 0; j < n_children; j++) + NVME_NS_CHANGED(children[j], i + 1); + } free(children, M_TEMP); } diff --git a/sys/dev/nvme/nvme_private.h b/sys/dev/nvme/nvme_private.h index ec941f31779c..5a83966ba729 100644 --- a/sys/dev/nvme/nvme_private.h +++ b/sys/dev/nvme/nvme_private.h @@ -232,6 +232,7 @@ struct nvme_controller { #define QUIRK_APPLE_SHARED_CID_SPACE 0x20 /* Admin/IO share a single CID table */ #define QUIRK_APPLE_NO_ASYNC_EVENT 0x40 /* Skip NVMe async event requests */ #define QUIRK_APPLE_SINGLE_VECTOR 0x80 /* Single MSI vector, one IO queue */ +#define QUIRK_EMPTY_NAMESPACE_CHANGED_LOG 0x100 /* Change Namespace List Log is always empty */ int resource_id; struct resource *resource;