From owner-cvs-all@FreeBSD.ORG  Thu Dec 11 00:59:44 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3DE8F16A4CE; Thu, 11 Dec 2003 00:59:44 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D5AC743D2C; Thu, 11 Dec 2003 00:59:41 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id TAA00658;
	Thu, 11 Dec 2003 19:59:38 +1100
Date: Thu, 11 Dec 2003 19:59:37 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Peter Grehan <grehan@freebsd.org>
In-Reply-To: <3FD7FD29.7050803@freebsd.org>
Message-ID: <20031211194303.X10479@gamplex.bde.org>
References: <200312100917.hBA9H26R081659@repoman.freebsd.org>
 <3FD6F0F2.4955B5B2@freebsd.org> <xzpbrqgn11y.fsf@dwp.des.no>
 <3FD7CD6A.8010909@freebsd.org> <20031211030704.GA53066@dragon.nuxi.com>
 <3FD7FD29.7050803@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: obrien@freebsd.org
Subject: Re: cvs commit: src/sys/boot/powerpc/loader conf.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Dec 2003 08:59:44 -0000

On Thu, 11 Dec 2003, Peter Grehan wrote:

> > If you can wait until the last week of December, I'd be glad to
> > do that.
>
>   That'd be great. The diffs are at www.freebsd.org/~grehan/schar.diff,
> with maybe the only controversial one being the style for ki_nice
> in the kinfo_proc structure.

These changes seem to be basically correct and have correct style
except for not merging the declarations of most of the new "int ch"
variables with the declarations of the other int variables.

The fix for kg_nice in proc.h is missing.  Only the relatively unimportant
declaration of ki_nice in user.h is fixed.

The fixes should be easy to test on i386's by compiling with -funsigned-char.
What bugs does putting negative niceness in the (unsigned) char variable
kg_nice cause?

Bruce