From owner-svn-ports-all@freebsd.org Wed Jun 26 01:19:01 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 88F5815DBFAE; Wed, 26 Jun 2019 01:19:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26F7E868C5; Wed, 26 Jun 2019 01:19:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id ED032207A5; Wed, 26 Jun 2019 01:19:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x5Q1J064069516; Wed, 26 Jun 2019 01:19:00 GMT (envelope-from bdrewery@FreeBSD.org) Received: (from bdrewery@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x5Q1J0F4069515; Wed, 26 Jun 2019 01:19:00 GMT (envelope-from bdrewery@FreeBSD.org) Message-Id: <201906260119.x5Q1J0F4069515@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bdrewery set sender to bdrewery@FreeBSD.org using -f From: Bryan Drewery Date: Wed, 26 Jun 2019 01:19:00 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r505131 - head/Mk/Scripts X-SVN-Group: ports-head X-SVN-Commit-Author: bdrewery X-SVN-Commit-Paths: head/Mk/Scripts X-SVN-Commit-Revision: 505131 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 26F7E868C5 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.92 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.92)[-0.919,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jun 2019 01:19:01 -0000 Author: bdrewery Date: Wed Jun 26 01:19:00 2019 New Revision: 505131 URL: https://svnweb.freebsd.org/changeset/ports/505131 Log: generate-symbols: Commit a working version. This file originated from Isilon's codebase. When I upstreamed it originally I refactored it to a broken version. This is now the working version. Debug files are purposely moved to LOCALBASE/lib/debug regardless of what PREFIX is. Sponsored by: DellEMC Modified: head/Mk/Scripts/generate-symbols.sh Modified: head/Mk/Scripts/generate-symbols.sh ============================================================================== --- head/Mk/Scripts/generate-symbols.sh Wed Jun 26 01:07:41 2019 (r505130) +++ head/Mk/Scripts/generate-symbols.sh Wed Jun 26 01:19:00 2019 (r505131) @@ -1,6 +1,13 @@ #! /bin/sh # $FreeBSD$ # Maintainer: portmgr@FreeBSD.org +# +# This script will find all ELF files in STAGEDIR and then strip and move +# the symbols to LOCALBASE/lib/debug/. +# For example: +# /var/qmail/bin/qmaild -> /usr/local/lib/debug/var/qmail/bin/qmaild.debug +# /usr/local/bin/ssh -> /usr/local/lib/debug/usr/local/bin/ssh +LIB_DIR_PREFIX="${LOCALBASE}/lib/debug" msg() { echo "====> $*" @@ -8,7 +15,7 @@ msg() { msg "Finding symbols" -# Find all ELF files, strip them, and move symbols to PREFIX/usr/lib/debug/ORIG_PATH +# Find all ELF files ELF_FILES=$(mktemp -t elf_files) find ${STAGEDIR} -type f \ -exec /usr/bin/readelf -S {} + 2>/dev/null | awk ' \ @@ -17,23 +24,23 @@ find ${STAGEDIR} -type f \ > ${ELF_FILES} # Create all of the /usr/local/lib/* dirs -lib_dir="${STAGEDIR}.debug${PREFIX}/lib/debug" -sed -e "s,^${STAGEDIR}${PREFIX}/,${lib_dir}/," -e 's,/[^/]*$,,' \ +lib_dir="${STAGEDIR}${LIB_DIR_PREFIX}" +sed -e "s,^${STAGEDIR}/,${lib_dir}/," -e 's,/[^/]*$,,' \ ${ELF_FILES} | sort -u | xargs mkdir -p while read -r staged_elf_file; do elf_file_name="${staged_elf_file##*/}" - lib_dir_dest="${lib_dir}/${staged_elf_file#${STAGEDIR}${PREFIX}/}" + lib_dir_dest="${lib_dir}/${staged_elf_file#${STAGEDIR}/}" # Strip off filename lib_dir_dest="${lib_dir_dest%/*}" # Save symbols to f.debug - objcopy --only-keep-debug "${staged_elf_file}" \ - "${lib_dir_dest}/${elf_file_name}.debug" + debug_file_name="${lib_dir_dest}/${elf_file_name}.debug" + objcopy --only-keep-debug "${staged_elf_file}" "${debug_file_name}" # Strip and add a reference to f.debug for finding the symbols. objcopy --strip-debug --strip-unneeded \ - --add-gnu-debuglink="${lib_dir_dest}/${elf_file_name}.debug" \ - "${staged_elf_file}" + --add-gnu-debuglink="${debug_file_name}" "${staged_elf_file}" msg "Saved symbols for ${staged_elf_file}" -done < ${ELF_FILES} + echo "${debug_file_name#${STAGEDIR}}" >&3 +done < ${ELF_FILES} 3>> ${TMPPLIST} rm -f ${ELF_FILES}