From owner-cvs-src@FreeBSD.ORG Wed Jan 2 21:17:52 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C92416A46B for ; Wed, 2 Jan 2008 21:17:52 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 4EE8F13C4DD for ; Wed, 2 Jan 2008 21:17:52 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 92566 invoked from network); 2 Jan 2008 21:17:52 -0000 Received: from 209-128-117-003.bayarea.net (HELO ?10.0.8.5?) (nate-mail@209.128.117.3) by root.org with ESMTPA; 2 Jan 2008 21:17:52 -0000 Message-ID: <477BFFD6.1080502@root.org> Date: Wed, 02 Jan 2008 13:19:18 -0800 From: Nate Lawson User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Poul-Henning Kamp References: <1429.1199308501@critter.freebsd.dk> In-Reply-To: <1429.1199308501@critter.freebsd.dk> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2008 21:17:52 -0000 Poul-Henning Kamp wrote: > In message <477BFB9D.8070201@root.org>, Nate Lawson writes: >> Poul-Henning Kamp wrote: > >> Ok, but this still doesn't address the performance loss fixed by this >> 3-year-old patch: > > I think your patch is wrong because it moves the responsibility for > the performance in the wrong direction: We shouldn't have to care > about this in every single device driver. > > When I created bus_{read|write}_* that was mostly to reduce the > risk of repetive strain injuries for device driver writers, but > it was also an attempt to move the responsibility in the right > direction. > > rman and bus_space was sort of conceived separately, but it is > time they realize that they are indeed a couple so everybody don't > have to pretend how surprised they are to see them together at > this instant. I'm happy to see this encapsulated, as long as it gets rid of the unnecessary overhead of what should be merely a structure member dereference. Thanks, -- Nate