From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 6 22:30:29 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4FF516A4E5 for ; Thu, 6 Jul 2006 22:30:29 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEEF243D55 for ; Thu, 6 Jul 2006 22:30:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k66MURk4027193 for ; Thu, 6 Jul 2006 22:30:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k66MURHA027192; Thu, 6 Jul 2006 22:30:27 GMT (envelope-from gnats) Date: Thu, 6 Jul 2006 22:30:27 GMT Message-Id: <200607062230.k66MURHA027192@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Ion-Mihai "IOnut" Tetcu Cc: Subject: Re: ports/99859: New port submission: xorp X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ion-Mihai IOnut Tetcu List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2006 22:30:29 -0000 The following reply was made to PR ports/99859; it has been noted by GNATS. From: Ion-Mihai "IOnut" Tetcu To: Benjamin Black Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: ports/99859: New port submission: xorp Date: Fri, 7 Jul 2006 01:20:25 +0300 --Sig_qox4/iyYNj9aI.1jlz6j8a6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 6 Jul 2006 22:03:45 GMT Benjamin Black wrote: >=20 > >Number: 99859 > >Category: ports > >Synopsis: New port submission: xorp > >Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: freebsd-ports-bugs > >State: open > >Quarter: =20 > >Keywords: =20 > >Date-Required: > >Class: change-request > >Submitter-Id: current-users > >Arrival-Date: Thu Jul 06 22:10:14 GMT 2006 > >Closed-Date: > >Last-Modified: > >Originator: Benjamin Black > >Release: 4.11 > >Organization: > >Environment: > FreeBSD elf.layer8.net 4.11-STABLE FreeBSD 4.11-STABLE #0: Mon Jun 12 09:= 45:06 PDT 2006 ben@elf.layer8.net:/usr/src/sys/compile/ELF_PROD_4_11_20= 060612 i386 >=20 > >Description: > # This is a shell archive. Save it in a file, remove anything before > # this line, and then unpack it by entering "sh file". Note, it may > # create directories; files and directories will be owned by you and > # have default permissions. > # > # This archive contains: > # > # xorp > # xorp/distinfo > # xorp/files > # xorp/files/patch-configure > # xorp/files/patch-configure-in > # xorp/files/patch-mibs-configure > # xorp/files/xorp.in > # xorp/Makefile > # xorp/pkg-deinstall > # xorp/pkg-descr > # xorp/pkg-plist > # > echo c - xorp > mkdir -p xorp > /dev/null 2>&1 > echo x - xorp/distinfo > sed 's/^X//' >xorp/distinfo << 'END-of-xorp/distinfo' > XMD5 (xorp-1.2.tar.gz) =3D 077cf64839fa0a177e6b6e6393f1c660 > XSHA256 (xorp-1.2.tar.gz) =3D 7e727c3500a6a74ff00114431ef556b2312e3e7e81b= 1a52c61a7e46093fd3999 > XSIZE (xorp-1.2.tar.gz) =3D 8765558 > END-of-xorp/distinfo > echo c - xorp/files > mkdir -p xorp/files > /dev/null 2>&1 > echo x - xorp/files/patch-configure > sed 's/^X//' >xorp/files/patch-configure << 'END-of-xorp/files/patch-conf= igure' > X--- configure.orig Tue Jul 4 22:25:12 2006 > X+++ configure Tue Jul 4 22:25:58 2006 > X@@ -15438,8 +15438,6 @@ > X=20 > X=20 > X case "${host_os}" in > X- *bsd*) FLOWER_MALLOC=3Dflower_malloc ;; > X- linux*) FLOWER_MALLOC=3Dflower_malloc ;; > X *) ;; > X esac > X=20 > X@@ -16135,7 +16133,7 @@ > X=20 > X=20 > X=20 > X-ac_config_files=3D"$ac_config_files Makefile MakefileRootCheck bgp/Make= file bgp/harness/Makefile bgp/tools/Makefile cli/Makefile cli/tools/Makefil= e contrib/Makefile docs/Makefile docs/bgp/Makefile docs/design_arch/Makefil= e docs/fea/Makefile docs/libxipc/Makefile docs/libxorp/Makefile docs/mfea/M= akefile docs/mld6igmp/Makefile docs/multicast/Makefile docs/pim/Makefile do= cs/pim_testsuite/Makefile docs/rib/Makefile docs/rtrmgr/Makefile docs/slide= s/Makefile docs/slides/status_2004_02/Makefile docs/snmp/Makefile docs/test= _harness/Makefile docs/user_manual/Makefile docs/xorpdev_101/Makefile etc/M= akefile etc/templates/Makefile fea/Makefile fea/MakefileRootCheck fea/tools= /Makefile fib2mrib/Makefile libcomm/Makefile libfeaclient/Makefile libproto= /Makefile libxipc/Makefile libxorp/Makefile mld6igmp/Makefile mrt/Makefile = ospf/Makefile ospf/tools/Makefile pim/Makefile policy/Makefile policy/backe= nd/Makefile policy/common/Makefile policy/test/Makefile rib/Makefile rib/to= ols/Makefile rip/Ma > kefile rip/tools/Makefile rtrmgr/Makefile static_routes/Makefile utils/M= akefile utils/flower_malloc/Makefile xrl/Makefile xrl/interfaces/Makefile x= rl/targets/Makefile xrl/tests/Makefile" > X+ac_config_files=3D"$ac_config_files Makefile MakefileRootCheck bgp/Make= file bgp/harness/Makefile bgp/tools/Makefile cli/Makefile cli/tools/Makefil= e contrib/Makefile docs/Makefile docs/bgp/Makefile docs/design_arch/Makefil= e docs/fea/Makefile docs/libxipc/Makefile docs/libxorp/Makefile docs/mfea/M= akefile docs/mld6igmp/Makefile docs/multicast/Makefile docs/pim/Makefile do= cs/pim_testsuite/Makefile docs/rib/Makefile docs/rtrmgr/Makefile docs/slide= s/Makefile docs/slides/status_2004_02/Makefile docs/snmp/Makefile docs/test= _harness/Makefile docs/user_manual/Makefile docs/xorpdev_101/Makefile etc/M= akefile etc/templates/Makefile fea/Makefile fea/MakefileRootCheck fea/tools= /Makefile fib2mrib/Makefile libcomm/Makefile libfeaclient/Makefile libproto= /Makefile libxipc/Makefile libxorp/Makefile mld6igmp/Makefile mrt/Makefile = ospf/Makefile ospf/tools/Makefile pim/Makefile policy/Makefile policy/backe= nd/Makefile policy/common/Makefile policy/test/Makefile rib/Makefile rib/to= ols/Makefile rip/Ma > kefile rip/tools/Makefile rtrmgr/Makefile static_routes/Makefile utils/M= akefile xrl/Makefile xrl/interfaces/Makefile xrl/targets/Makefile xrl/tests= /Makefile" > X ac_config_commands=3D"$ac_config_commands default" > X cat >confcache <<\_ACEOF > X # This file is a shell script that caches the results of configure > X@@ -16673,7 +16671,6 @@ > X "rtrmgr/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES rtrmgr/Makefile" ;; > X "static_routes/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES static_route= s/Makefile" ;; > X "utils/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES utils/Makefile" ;; > X- "utils/flower_malloc/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES utils/= flower_malloc/Makefile" ;; > X "xrl/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES xrl/Makefile" ;; > X "xrl/interfaces/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES xrl/interfa= ces/Makefile" ;; > X "xrl/targets/Makefile" ) CONFIG_FILES=3D"$CONFIG_FILES xrl/targets/Ma= kefile" ;; > END-of-xorp/files/patch-configure > echo x - xorp/files/patch-configure-in > sed 's/^X//' >xorp/files/patch-configure-in << 'END-of-xorp/files/patch-c= onfigure-in' > X--- configure.in.orig Tue Jul 4 22:25:21 2006 > X+++ configure.in Tue Jul 4 22:26:40 2006 > X@@ -807,14 +807,9 @@ > X dnl utils/flower_malloc related > X dnl -------------------------------------------------------------------= -------- > X=20 > X-dnl flower_malloc in utils is an interposer and is only known to > X-dnl work on systems supporting -shared. AFAICT this needs some work for > X-dnl a real test. As a stop gap, we assume that if we are on *BSD or Li= nux > X-dnl things work okay. Only known failure case is OS X. > X+dnl disabled in FreeBSD 6.1 port > X=20 > X case "${host_os}" in > X- *bsd*) FLOWER_MALLOC=3Dflower_malloc ;; > X- linux*) FLOWER_MALLOC=3Dflower_malloc ;; > X *) ;; > X esac > X AC_SUBST(FLOWER_MALLOC) > END-of-xorp/files/patch-configure-in > echo x - xorp/files/patch-mibs-configure > sed 's/^X//' >xorp/files/patch-mibs-configure << 'END-of-xorp/files/patch= -mibs-configure' > X--- mibs/configure.orig Tue Jul 4 16:53:56 2006 > X+++ mibs/configure Tue Jul 4 16:54:09 2006 > X@@ -5003,7 +5003,7 @@ > X # MIB support. dummy MIB modules will only generate warnings > X echo 'dlmod dummy doubledummy' > conftestsnmp.conf > X test_ports=3D'51510 51520 51530 51540 51550' > X- snmpd_base_args=3D"-f -r -l conftestsnmp.log -c conftestsnmp.conf" > X+ snmpd_base_args=3D"-f -r -Lf conftestsnmp.log -c conftestsnmp.conf" > X # On Linux snmpd seems to need the "-p" flag. > X for args in "" "-p" > X do > END-of-xorp/files/patch-mibs-configure > echo x - xorp/files/xorp.in > sed 's/^X//' >xorp/files/xorp.in << 'END-of-xorp/files/xorp.in' > X#!/bin/sh > X# > X# $FreeBSD$ > X# > X# PROVIDE: xorp > X# REQUIRE: netif routing mountcritlocal > X# BEFORE: NETWORKING > X > X# Add the following lines to /etc/rc.conf to run xorp: > X# > X# xorp_enable (bool): Set it to "YES" to enable xorp. > X# Default is "NO". > X# xorp_config (file): Set configuration file for xorp. > X# Default is "%%PREFIX%%/etc/xorp.conf". > X# > X > X. /etc/rc.subr > X > Xname=3D"xorp" > Xrcvar=3D${name}_enable > X > Xload_rc_config ${name} > X > X: ${xorp_enable=3D"NO"} > X: ${xorp_config=3D"%%PREFIX%%/etc/xorp.conf"} > X > Xcommand=3D%%PREFIX%%/bin/xorp_rtrmgr > Xcommand_args=3D"-b ${xorp_config}" > X > Xrun_rc_command "$1" > END-of-xorp/files/xorp.in Please check this against the example in Porters Handbook. > echo x - xorp/Makefile > sed 's/^X//' >xorp/Makefile << 'END-of-xorp/Makefile' > X# New ports collection makefile for: xorp > X# Date created: 25 June 2006 > X# Whom: bb > X# > X# $FreeBSD$ > X# > X > XPORTNAME=3D xorp > XPORTVERSION=3D 1.2 > XCATEGORIES=3D net > XMASTER_SITES=3D http://www.xorp.org/releases/1.2/ > X > XMAINTAINER=3D ben@layer8.net > XCOMMENT=3D Open source routing protocol suite > X > XHAS_CONFIGURE=3D yes > XUSE_GMAKE=3D yes > X > XCONFIGURE_TARGET=3D --build=3D${MACHINE_ARCH}-portbld-freebsd${OSRE= L} > XCONFIGURE_ARGS=3D --prefix=3D${PREFIX} \ > X ${CONFIGURE_TARGET} \ > X --with-comment=3D'FreeBSD port: ${PKGNAME}' \ > X --enable-shared > X > XOPTIONS=3D OPENSSL "Enable SSL" off \ > X SNMP "Enable SNMP" off \ > X IPV6 "Enable IPv6 support" off > X > X.include > X > XXORP_GROUP=3D xorp > XUSE_RC_SUBR=3D xorp > X > X.if defined(WITH_OPENSSL) > XCONFIGURE_ARGS+=3D--with-openssl=3D/usr > X.endif > X.if defined(WITHOUT_IPV6) > XCONFIGURE_ARGS+=3D--disable-ipv6 > X.endif > X.if defined(WITH_SNMP) > XCONFIGURE_ARGS+=3D --with-snmp > XBUILD_DEPENDS+=3D snmpd:${PORTSDIR}/net-mgmt/net-snmp \ > X net-snmp-config:${PORTSDIR}/net-mgmt/net-snmp > XPLIST_SUB+=3D XORP_SNMP=3D"" > X.else > XPLIST_SUB+=3D XORP_SNMP=3D"@comment " > X.endif Please fix the way you check the OPTIONS (see PH chapter on this). > X > Xpost-install: > X @if [ ! -f ${PREFIX}/etc/xorp.conf.sample ]; then \ > X ${CP} ${WRKSRC}/rtrmgr/config.boot.sample ${PREFIX}/etc/x= orp.conf.sample; \ > X fi > X @if pw group show "${XORP_GROUP}" 2>/dev/null; then \ > X ${ECHO} "You already have a group \"${XORP_GROUP}\", so = I will use it."; \ > X else \ > X ${ECHO} "Adding group \"${XORP_GROUP}\"."; \ > X pw groupadd -n ${XORP_GROUP} 2>/dev/null; \ > X fi You need to do this in pkg_install and call pkg-install here instead (else the package will be broken). --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" BOFH excuse #384: it's an ID-10-T error --Sig_qox4/iyYNj9aI.1jlz6j8a6 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFErYyqBX6fi0k6KXsRAqSEAJ0WIzVnnonlDphdmlFwRh6gXA5mzQCeKnJo /sjVzDhtyuPzsgn58FktncA= =HpZI -----END PGP SIGNATURE----- --Sig_qox4/iyYNj9aI.1jlz6j8a6--