From owner-svn-src-all@FreeBSD.ORG Fri Mar 9 15:45:02 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 470161065675; Fri, 9 Mar 2012 15:45:02 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) by mx1.freebsd.org (Postfix) with ESMTP id A97F68FC14; Fri, 9 Mar 2012 15:45:01 +0000 (UTC) Received: from [192.168.1.103] (p508FA066.dip.t-dialin.net [80.143.160.102]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id E96391C0C0BCC; Fri, 9 Mar 2012 16:44:58 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset=us-ascii From: Michael Tuexen In-Reply-To: <6E2D25B4-B9BC-4D51-98BF-FDE1EDDED7CB@lists.zabbadoz.net> Date: Fri, 9 Mar 2012 16:44:57 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201203091312.q29DCXLJ008313@svn.freebsd.org> <6E2D25B4-B9BC-4D51-98BF-FDE1EDDED7CB@lists.zabbadoz.net> To: Bjoern A. Zeeb X-Mailer: Apple Mail (2.1257) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232723 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 15:45:02 -0000 On Mar 9, 2012, at 3:08 PM, Bjoern A. Zeeb wrote: >=20 > On 9. Mar 2012, at 13:12 , Michael Tuexen wrote: >=20 >> Author: tuexen >> Date: Fri Mar 9 13:12:33 2012 >> New Revision: 232723 >> URL: http://svn.freebsd.org/changeset/base/232723 >>=20 >> Log: >> Fix a bug reported by Peter Holm which results in a crash: >> Verify in sctp_peeloff() that the socket is a one-to-many >> style SCTP socket. >=20 > /scratch/tmp/bz/head.svn/sys/netinet/sctp_peeloff.c: In function = 'sctp_can_peel_off': > /scratch/tmp/bz/head.svn/sys/netinet/sctp_peeloff.c:59: warning: 'inp' = is used uninitialized in this function Fixed in http://svn.freebsd.org/changeset/base/232726 Thanks for the report. Best regards Michael >=20 >=20 >>=20 >> MFC after: 3 days. >>=20 >> Modified: >> head/sys/netinet/sctp_peeloff.c >>=20 >> Modified: head/sys/netinet/sctp_peeloff.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/netinet/sctp_peeloff.c Fri Mar 9 13:06:24 2012 = (r232722) >> +++ head/sys/netinet/sctp_peeloff.c Fri Mar 9 13:12:33 2012 = (r232723) >> @@ -55,6 +55,15 @@ sctp_can_peel_off(struct socket *head, s >> struct sctp_tcb *stcb; >> uint32_t state; >>=20 >> + if (head =3D=3D NULL) { >> + SCTP_LTRACE_ERR_RET(inp, NULL, NULL, = SCTP_FROM_SCTP_PEELOFF, EBADF); >> + return (EBADF); >> + } >> + if ((head->so_proto->pr_protocol !=3D IPPROTO_SCTP) || >> + (head->so_type !=3D SOCK_SEQPACKET)) { >> + SCTP_LTRACE_ERR_RET(inp, NULL, NULL, = SCTP_FROM_SCTP_PEELOFF, EOPNOTSUPP); >> + return (EOPNOTSUPP); >> + } >> inp =3D (struct sctp_inpcb *)head->so_pcb; >> if (inp =3D=3D NULL) { >> SCTP_LTRACE_ERR_RET(inp, NULL, NULL, = SCTP_FROM_SCTP_PEELOFF, EFAULT); >=20 > --=20 > Bjoern A. Zeeb You have to have = visions! > It does not matter how good you are. It matters what good you do! >=20 >=20