From owner-svn-src-all@freebsd.org Sat Jul 14 15:45:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 104EF102FAB5; Sat, 14 Jul 2018 15:45:12 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A85827DEC7; Sat, 14 Jul 2018 15:45:11 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 83EA320FC1; Sat, 14 Jul 2018 15:45:11 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w6EFjBmp000955; Sat, 14 Jul 2018 15:45:11 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w6EFjBT0000954; Sat, 14 Jul 2018 15:45:11 GMT (envelope-from cem@FreeBSD.org) Message-Id: <201807141545.w6EFjBT0000954@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: Conrad Meyer Date: Sat, 14 Jul 2018 15:45:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r336280 - head/sys/ufs/ffs X-SVN-Group: head X-SVN-Commit-Author: cem X-SVN-Commit-Paths: head/sys/ufs/ffs X-SVN-Commit-Revision: 336280 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2018 15:45:12 -0000 Author: cem Date: Sat Jul 14 15:45:11 2018 New Revision: 336280 URL: https://svnweb.freebsd.org/changeset/base/336280 Log: ffs_syncvnode: Remove unhelpful print It can occur during ordinary use of softupdates, or perhaps if writes to the underlying media fail (causing bufs to be redirtied). Either way, it is not particularly actionable. Reviewed by: imp, kib Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D16258 Modified: head/sys/ufs/ffs/ffs_vnops.c Modified: head/sys/ufs/ffs/ffs_vnops.c ============================================================================== --- head/sys/ufs/ffs/ffs_vnops.c Sat Jul 14 15:32:36 2018 (r336279) +++ head/sys/ufs/ffs/ffs_vnops.c Sat Jul 14 15:45:11 2018 (r336280) @@ -377,10 +377,6 @@ next: wait = !wait; if (wait || ++passes < UFS_NIADDR + 2) goto loop; -#ifdef INVARIANTS - if (!vn_isdisk(vp, NULL)) - vn_printf(vp, "ffs_fsync: dirty "); -#endif } } BO_UNLOCK(bo);