From owner-freebsd-ports Fri Aug 16 10:11:16 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2769F37B400 for ; Fri, 16 Aug 2002 10:11:14 -0700 (PDT) Received: from mailout08.sul.t-online.com (mailout08.sul.t-online.com [194.25.134.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 898F943E42 for ; Fri, 16 Aug 2002 10:11:13 -0700 (PDT) (envelope-from Alexander@Leidinger.net) Received: from fwd05.sul.t-online.de by mailout08.sul.t-online.com with smtp id 17fkcx-00028k-07; Fri, 16 Aug 2002 19:11:11 +0200 Received: from Andro-Beta.Leidinger.net (520065502893-0001@[80.131.126.150]) by fmrl05.sul.t-online.com with esmtp id 17fkcl-0bECWmC; Fri, 16 Aug 2002 19:10:59 +0200 Received: from Magelan.Leidinger.net (Magelan [192.168.1.1]) by Andro-Beta.Leidinger.net (8.11.6/8.11.6) with ESMTP id g7GHAwx72693; Fri, 16 Aug 2002 19:10:58 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from Magelan.Leidinger.net (netchild@localhost [127.0.0.1]) by Magelan.Leidinger.net (8.12.5/8.12.5) with SMTP id g7GHAvTv066487; Fri, 16 Aug 2002 19:10:57 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Date: Fri, 16 Aug 2002 19:10:56 +0200 From: Alexander Leidinger To: Christian Weisgerber Cc: freebsd-ports@FreeBSD.ORG Subject: Re: ports/41710: [port] lame update (fix CFLAGS) Message-Id: <20020816191056.0a9a3b2c.Alexander@Leidinger.net> In-Reply-To: <200208161640.g7GGe3Dh028390@freefall.freebsd.org> References: <200208161640.g7GGe3Dh028390@freefall.freebsd.org> Organization: Independend X-Mailer: Sylpheed version 0.8.1claws (GTK+ 1.2.10; i386-portbld-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Sender: 520065502893-0001@t-dialin.net Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, 16 Aug 2002 09:40:03 -0700 (PDT) Christian Weisgerber wrote: > > There's no need to remove "OPTIMIZATION": as long as nobody uses > > "--enable-expopt={yes,full}" for configure, it doesn't get used. > > Wrong. Further down in configure, there's an assignment > CFLAGS="${OPTIMIZATION} ${CFLAGS}". This isn't worth arguing about, > just go and test it yourself. Argh! Ok, the lines which where supposed to do it got lost somewhere, will be fixed in LAME CVS soon. > > What's wrong with adding "-Wall -pipe" to CFLAGS? > > *I* want to decide if I build with "-pipe" or without. And if I I know only one bugreport with "-pipe", Irix doesn't seem to like it. Besides this, every OS seems to accept it. Normaly it speeds up the build. So why do we need to patch it (nitpicking on "-pipe" seems to be a bikeshed argument for me)? > want to, then what's the point of "-pipe -pipe"? "-Wall" doesn't > add anything outside development. It isn't harmfull. We do we need to add a patch for it? > Basically these happened to be nearby, so I removed them along with > the other cruft that killed the compile on -CURRENT/alpha. Can you be more specific please? Bye, Alexander. -- Where do you think you're going today? http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message