From owner-cvs-all Sat Sep 28 17: 6:42 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7ECF937B401; Sat, 28 Sep 2002 17:06:41 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F8C243E65; Sat, 28 Sep 2002 17:06:40 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id KAA22662; Sun, 29 Sep 2002 10:06:38 +1000 Date: Sun, 29 Sep 2002 10:15:56 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi_low.c scsi_ses.c src/sys/ddb db_input.c db_watch.c src/sys/dev/advansys advansys.c src/sys/dev/aic aic.c src/sys/dev/aic7xxx aic7x In-Reply-To: <200209281715.g8SHFdHm060297@freefall.freebsd.org> Message-ID: <20020929101051.Q39375-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 28 Sep 2002, Poul-Henning Kamp wrote: > phk 2002/09/28 10:15:39 PDT > > Modified files: > sys/cam/scsi scsi_cd.c scsi_ch.c scsi_low.c scsi_ses.c > sys/ddb db_input.c db_watch.c > .... > sys/vm swap_pager.c uma_core.c vm_glue.c > vnode_pager.c > Log: > Be consistent about "static" functions: if the function is marked > static in its prototype, mark it static at the definition too. > > Inspired by: FlexeLint warning #512 This just fixes style bugs. It is a "feature" of C that storage and linkage declarators can sometimes be left out and/or added to in new declarations (usually in cases where this is least useful, especially when combined with gcc's -Wredundant-decls which tends to warn about all the cases which might be useful because they aren't actually redundant). Lots of these style bugs were created by sloppy staticization. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message