From owner-svn-src-head@freebsd.org Sun Mar 25 17:31:06 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 526CEF5BEBE for ; Sun, 25 Mar 2018 17:31:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8FB06F5D4 for ; Sun, 25 Mar 2018 17:31:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22e.google.com with SMTP id 19-v6so7991533itw.3 for ; Sun, 25 Mar 2018 10:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0higJyM+KY3i8lfsdrQfPLobsEwQGk39B9yY6Sbv3pQ=; b=N1bLzgSjl7nS8T8yUZHmJwc+izM5HNFwbIcwkF7UFMkWoz8fNzu2BK5wa7x0Q7/Pow BfejXi4arirW6COMEdsSSNkm/iHldd6e+G+NJWmliggyaQR1gv/ltmGfkxf/TskGM6sS ph7QfdC7JAn633EFqC3TsjVobfk5AptslFn2KXKa3/dmescxy43r3/dzcn0mj9xkPBn4 7kNB4gGkaUEoNELa27ZCrQAACr1z4MEbLM0aKiCQwcx6zXqvYSUJYPSGWRDduM5LRwhM v/YjhGjbwPFC3nnEensiMZh4MVs1as8Np+hDxDywkmnu2g43qYyWkkKq+WyvPDVMK1yk LDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0higJyM+KY3i8lfsdrQfPLobsEwQGk39B9yY6Sbv3pQ=; b=qs6CIMwnCEaUxnJVufunWgSnjE6vYUlCuGLa9UTlSlpuU00426V6XByHDFDuedDx76 rssUHORDNybXVb5we2hDYRPUXUtRH7FHKDjVPWbsdFCG4Endd3HDjet7gzuNrxf8f4Wf usUaEqoa3jwRsV8XyYRLzwhezDl3K+3SHPAomvtUtv3khksaPnPhK+6Z3NEqx0L68uga P/kVoGfhsddw6S87uT6iJf3F4Tcmj3WnxzgcWRW8rE+aspo/0LJm9WlcA4cvNMggtD7g VuekIbtR4mGlEIqGopRKcBvcCAjqE/p3C+URrWvVJ1+hz1FidmfVplRtrVtJT9Tth/IB u1dw== X-Gm-Message-State: AElRT7EMGF2xRM+7zLHX4O24oo0Uj3TK82f109SHEIkIGH9QCCLvDjzy pqm9BO1sVr6Port2CJdWaCKTYcpC0v3QbBdIIsVD8w== X-Google-Smtp-Source: AIpwx49rXgMCxcsYYccoxAsAxMsLzve/LE4s1DmzGZjQvxgQUoaKiMA/a8tUrNlzoTU9rgl7UlgqXeNQdrT3ojdJwV4= X-Received: by 2002:a24:6f04:: with SMTP id x4-v6mr4558272itb.51.1521999065256; Sun, 25 Mar 2018 10:31:05 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Sun, 25 Mar 2018 10:31:04 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <1521997216.49673.2.camel@freebsd.org> References: <201803251656.w2PGunC0061278@repo.freebsd.org> <1521997216.49673.2.camel@freebsd.org> From: Warner Losh Date: Sun, 25 Mar 2018 11:31:04 -0600 X-Google-Sender-Auth: C7HulPBxgUBgxkOgBV0BXqCyymA Message-ID: Subject: Re: svn commit: r331532 - head/sys/crypto/ccp To: Ian Lepore Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 17:31:06 -0000 On Sun, Mar 25, 2018 at 11:00 AM, Ian Lepore wrote: > On Sun, 2018-03-25 at 16:56 +0000, Warner Losh wrote: > > Author: imp > > Date: Sun Mar 25 16:56:49 2018 > > New Revision: 331532 > > URL: https://svnweb.freebsd.org/changeset/base/331532 > > > > Log: > > The PNP info has to follow the module definition. Move it from just > > after the array to its proper location. Otherwise, the linker.hints > > file has things out of order and we associated it with whatever was > > the previous module. > > Wow, that seems like a subtle thing that'll be easy to get wrong and > hard to detect when you have. Would it be possible for the PNP macro > to have some kind of reference to the structures generated by the > module definition macro, to force a compile-time error if they're out > of order? > Yes. I'm working on the best way to enforce it. The easy way is in kldxref, but I'm pondering ways to do it at compile time. Warner