From owner-freebsd-current@FreeBSD.ORG Fri Jun 11 15:47:39 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 512C216A4CE for ; Fri, 11 Jun 2004 15:47:39 +0000 (GMT) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81F3243D46 for ; Fri, 11 Jun 2004 15:47:38 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru id i5BFi8KX049764 for current@FreeBSD.org.checked; (8.12.8/vak/2.1) Fri, 11 Jun 2004 19:44:08 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (hi.cronyx.ru [144.206.181.94]) by hanoi.cronyx.ru with ESMTP id i5BFhW92049681; (8.12.8/vak/2.1) Fri, 11 Jun 2004 19:43:32 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <40C9D2DE.8050205@cronyx.ru> Date: Fri, 11 Jun 2004 19:42:22 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Evans References: <69020.1086934568@critter.freebsd.dk> <20040611210929.J13443@gamplex.bde.org> In-Reply-To: <20040611210929.J13443@gamplex.bde.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Poul-Henning Kamp cc: current@FreeBSD.org Subject: Re: kernel dev_t elimination patch for review X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2004 15:47:39 -0000 Bruce Evans wrote: >On Fri, 11 Jun 2004, Poul-Henning Kamp wrote: > > > >> http://phk.freebsd.dk/patch/dev_t.patch >> >>This patch changes "dev_t" in the kernel to "struct cdev *" >>and is 337K of boredom like: >> >> -static dev_t perfdev; >> +static struct cdev *perfdev; >> >>People who maintain cross-platform or cross-version source code in >>the kernel, should take a close look at this patch. >> >>If you don't like the way I have done it (which is mostly automated) >>you are more than welcome to commit your own patch, all you have >>to do is use "struct cdev *" instead of "dev_t", and you can do >>that already now. >> >> > >This mangles the formatting in approximately 10% of cases (mainly for >dev_t\t\t and for almost all dev_t's in structs; in structs it tends >to misindent both the member name and the comment). > > Probably this could be solved by local definition of dev_t as a struct cdev. This would much easy than fixing formatting in every file. After that code maintaners can keep it or change whatever they wish. rik >Bruce >_______________________________________________ >freebsd-current@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-current >To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > >