Date: Fri, 11 Jun 2004 19:42:22 +0400 From: Roman Kurakin <rik@cronyx.ru> To: Bruce Evans <bde@zeta.org.au> Cc: current@FreeBSD.org Subject: Re: kernel dev_t elimination patch for review Message-ID: <40C9D2DE.8050205@cronyx.ru> In-Reply-To: <20040611210929.J13443@gamplex.bde.org> References: <69020.1086934568@critter.freebsd.dk> <20040611210929.J13443@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: >On Fri, 11 Jun 2004, Poul-Henning Kamp wrote: > > > >> http://phk.freebsd.dk/patch/dev_t.patch >> >>This patch changes "dev_t" in the kernel to "struct cdev *" >>and is 337K of boredom like: >> >> -static dev_t perfdev; >> +static struct cdev *perfdev; >> >>People who maintain cross-platform or cross-version source code in >>the kernel, should take a close look at this patch. >> >>If you don't like the way I have done it (which is mostly automated) >>you are more than welcome to commit your own patch, all you have >>to do is use "struct cdev *" instead of "dev_t", and you can do >>that already now. >> >> > >This mangles the formatting in approximately 10% of cases (mainly for >dev_t\t\t and for almost all dev_t's in structs; in structs it tends >to misindent both the member name and the comment). > > Probably this could be solved by local definition of dev_t as a struct cdev. This would much easy than fixing formatting in every file. After that code maintaners can keep it or change whatever they wish. rik >Bruce >_______________________________________________ >freebsd-current@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-current >To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40C9D2DE.8050205>