Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 02 Dec 2012 06:23:44 -0500
From:      "Jason E. Hale" <jhale@freebsd.org>
To:        TAKATSU Tomonari <tota@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308088 - head/mail/libpst
Message-ID:  <2067599.aZpKqZiZHh@mocha.verizon.net>
In-Reply-To: <201212020252.qB22q32V058287@svn.freebsd.org>
References:  <201212020252.qB22q32V058287@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, December 02, 2012 02:52:03 TAKATSU Tomonari wrote:
> Author: tota
> Date: Sun Dec  2 02:52:03 2012
> New Revision: 308088
> URL: http://svnweb.freebsd.org/changeset/ports/308088
> 
> Log:
>   - Update to 0.6.55
>   - Convert to new Makefile header
>   - Add an entry to MASTER_SITES
>   - Add LICENSE
>   - Convert to new options framework
>   - Make use of PORTDOCS
>   - Remove specific ABI version number from LIB_DEPENDS
> 
>   PR:		ports/174013
>   Submitted by:	tota (myself)
>   Approved by:	maintainer
>   Feature safe:	yes
> 
> Modified:
>   head/mail/libpst/Makefile
>   head/mail/libpst/distinfo
>   head/mail/libpst/pkg-plist
> 
> Modified: head/mail/libpst/Makefile
> ============================================================================
> == --- head/mail/libpst/Makefile	Sun Dec  2 02:43:54 2012	(r308087)
> +++ head/mail/libpst/Makefile	Sun Dec  2 02:52:03 2012	(r308088)
> @@ -1,18 +1,17 @@
> -# New ports collection makefile for:   libpst
> -# Date created:        28 June 2002
> -# Whom:                Nate Underwood <natey@natey.com>
> -#
> +# Created by: Nate Underwood <natey@natey.com>
>  # $FreeBSD$
> -#
> 
>  PORTNAME=	libpst
> -PORTVERSION=	0.6.53
> +PORTVERSION=	0.6.55
>  CATEGORIES=	mail converters
> -MASTER_SITES=	http://www.five-ten-sg.com/libpst/packages/
> +MASTER_SITES=	http://www.five-ten-sg.com/libpst/packages/ \
> +		http://fossies.org/unix/privat/
> 
>  MAINTAINER=	chifeng@gmail.com
>  COMMENT=	A tool for converting Outlook .pst files to mbox and other formats
> 

Leading indefinite article should be removed from COMMENT.

> +LICENSE=	GPLv2
> +
>  GNU_CONFIGURE=	yes
>  USE_GMAKE=	yes
>  USE_ICONV=	yes
> @@ -20,18 +19,23 @@ CPPFLAGS+=	-I${LOCALBASE}/include
>  LDFLAGS+=	-L${LOCALBASE}/lib -liconv
>  CONFIGURE_ARGS+=	--disable-python
> 
> -OPTIONS=	PST2DII "allow Summation Document Image Information output" off
> -
>  MAN1=	lspst.1 pst2dii.1 pst2ldif.1 readpst.1
>  MAN5=	outlook.pst.5
> 
> +OPTIONS_DEFINE=	DOCS PST2DII
> +PST2DII_DESC=	"allow Summation Document Image Information output"
> +

Descriptions should not have quotes.  It would be nice to capitalize the first 
word also.

>  .include <bsd.port.options.mk>
> 
> -.if defined(WITH_PST2DII)
> +.if ${PORT_OPTIONS:MDOCS}
> +PORTDOCS=	*
> +.endif
> +

PORTDOCS does not need to be wrapped with an .if statement.  It can go before 
<bsd.port.options.mk>.

-- 
Jason E. Hale - jhale@
FreeBSD Ports Committer
KDE/FreeBSD Team



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2067599.aZpKqZiZHh>