Date: Mon, 27 May 2019 18:57:17 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238138] [PATCH] acpi_dock(4): Notify devd(8) on dock status change Message-ID: <bug-238138-227-8w6z6omDjh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238138-227@https.bugs.freebsd.org/bugzilla/> References: <bug-238138-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238138 Mark Johnston <markj@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |markj@FreeBSD.org --- Comment #4 from Mark Johnston <markj@FreeBSD.org> --- (In reply to Muhammad Kaisar Arkhan from comment #3) Thanks. I applied the patches to my tree. A couple more comments: - Please use tabs for indentation next time. The style(9) man page documen= ts the kernel coding style. Admittedly, some of the ACPI code does not follow= it very well. - Why do you check for a running devd? Other ACPI subsystems don't bother.= =20 The event message is non-blocking and we will simply free the message if de= vd isn't running. We save some unnecessary work by checking first, but I'd ra= ther be consistent with the rest of the kernel unless there's a good reason here. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238138-227-8w6z6omDjh>