From owner-freebsd-stable@FreeBSD.ORG Wed Apr 16 10:08:56 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AD971065679; Wed, 16 Apr 2008 10:08:56 +0000 (UTC) (envelope-from ob@gruft.de) Received: from obh.snafu.de (v6.gruft.de [IPv6:2001:1560:2342::2]) by mx1.freebsd.org (Postfix) with ESMTP id AEB318FC0A; Wed, 16 Apr 2008 10:08:55 +0000 (UTC) (envelope-from ob@gruft.de) Received: from ob by obh.snafu.de with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1Jm4ZS-000Lgg-B7; Wed, 16 Apr 2008 12:08:54 +0200 Date: Wed, 16 Apr 2008 12:08:54 +0200 From: Oliver Brandmueller To: Doug Rabson Message-ID: <20080416100854.GS37437@e-Gitt.NET> Mail-Followup-To: Doug Rabson , freebsd-stable@freebsd.org, Doug Rabson References: <20080414071957.GJ37437@e-Gitt.NET> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Oliver Brandmueller Cc: Doug Rabson , freebsd-stable@freebsd.org Subject: Re: panic with smbfs after MFC of kernel space locking X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2008 10:08:56 -0000 Hi again, On Mon, Apr 14, 2008 at 08:55:49AM +0100, Doug Rabson wrote: >> Could anyone with a little better programming skills than me probably >> have a look at it? From the diffs of the other filesystems it seems like >> it's not a real big change, but mainly adding the function. > > I added a new vnode operation to support the new lock manager but this > operation only needs to be implemented on filesystems that can be exported > via NFS. I assumed that this was not the case for SMBFS. Could you find me > a line number for lf_getblock+0x2a - something like this should do it: To give short feedback on the issue: Doug Rabson sent me a patch (that's already commited to HEAD). With the patch I didn't observe a panic within the last 48 hours, so I consider the bug fixed. The MFC to 7-STABLE is scheduled as I could read from the commit log. Thanx, Oliver PS: This is the kind of great support I sometimes wish expensive closed source software would have, too! -- | Oliver Brandmueller | Offenbacher Str. 1 | Germany D-14197 Berlin | | Fon +49-172-3130856 | Fax +49-172-3145027 | WWW: http://the.addict.de/ | | Ich bin das Internet. Sowahr ich Gott helfe. | | Eine gewerbliche Nutzung aller enthaltenen Adressen ist nicht gestattet! |