Date: Mon, 23 Sep 2013 00:05:23 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r255804 - in head/contrib/llvm/lib: CodeGen/SelectionDAG Target/AArch64 Target/ARM Target/Hexagon Target/MSP430 Target/Mips Target/NVPTX Target/PowerPC Target/R600 Target/Sparc Target/S... Message-ID: <427467AD-F9D7-47AF-A271-DEB719985F18@FreeBSD.org> In-Reply-To: <201309222203.r8MM3UjJ006580@svn.freebsd.org> References: <201309222203.r8MM3UjJ006580@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 23, 2013, at 00:03, Dimitry Andric <dim@FreeBSD.org> wrote: > Author: dim > Date: Sun Sep 22 22:03:30 2013 > New Revision: 255804 > URL: http://svnweb.freebsd.org/changeset/base/255804 > > Log: > Pull in r191165 from upstream llvm trunk: > > ISelDAG: spot chain cycles involving MachineNodes > > Previously, the DAGISel function WalkChainUsers was spotting that it > had entered already-selected territory by whether a node was a > MachineNode (amongst other things). Since it's fairly common practice > to insert MachineNodes during ISelLowering, this was not the correct > check. > > Looking around, it seems that other nodes get their NodeId set to -1 > upon selection, so this makes sure the same thing happens to all > MachineNodes and uses that characteristic to determine whether we > should stop looking for a loop during selection. > > This should fix PR15840. > > Specifically, this fixes the long-standing assertion failure when > compiling the multimedia/gstreamer port on i386. Thanks to Tijl > Coosemans for his help in getting upstream to fix it. > > Approved by: re (marius) MFC after: 3 days --Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI/aaMACgkQsF6jCi4glqPOQwCfWhHkw2NxAtnzeNheaI9Wno7V 6CIAn0ICLjCrg8onPhj53dwjkhrlI6zz =rFia -----END PGP SIGNATURE----- --Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?427467AD-F9D7-47AF-A271-DEB719985F18>