Date: Thu, 30 Jun 2016 10:21:03 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, Bryan Drewery <bdrewery@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417364 - head/Mk/Scripts Message-ID: <685BD37565065F0C493733CE@atuin.in.mat.cc> In-Reply-To: <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> References: <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========AD08069337EC5D173BDE========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 30 juin 2016 07:41:09 +0200 Baptiste Daroussin <bapt@FreeBSD.org> wrote: | On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote: |> On 6/23/2016 4:31 AM, Mathieu Arnold wrote: |> > Author: mat |> > Date: Thu Jun 23 11:31:15 2016 |> > New Revision: 417364 |> > URL: https://svnweb.freebsd.org/changeset/ports/417364 |> > |> > Log: |> > Extend the symlink checks to warn on absolute targets. |> > |> > Sponsored by: Absolight |> > Differential Revision: https://reviews.freebsd.org/D6930 |> |> Why? This seems like noise. | | Quite true as it is I overlooked it. | | To ease relocatable packages (to prepare sysroot for exemple) symlinks | that points to file within the same package should be absolute links. | | After looking at this patch again I think it should be reverted and | replaced later by something that will check symlinks on the same plist Mmmm, I can add a check to see if the target is in STAGEDIR and only emit the warning if it is. -- Mathieu Arnold --==========AD08069337EC5D173BDE========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXdNZvXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IW4QP/i/xaSzfY1mkZr01RnbWRDrA BaNuZPV6+Kb2VS21jVml3+may5RJBP5HcRZiPoartQ/1VD/QHnHGA7zKwB+nydtN Lbzv4fdaamWDkZrFMRJeEAu2g7Dd2aj8KXhHp22NFjT3jr7JTjuTfAgi3Qx2l2WW eRyabRGPr+J/479/pN8UxVKtSnGCjw+NcPEfV3TNe5FrN1r7KRwbvsAO9j9tIPxv DjdRtCF2qddEWWsrPsZ/7IkMjJfWLfHSHpkZbvZ93EhaVL5tWXLf1BZe/p4q+f9h bxkA/BHmhASOzXQUEDRP37FkUrSJqxECF5Hm/TSs1pPlkdW0sQnc02Np4aanjOiV 2kD0dqHtN+a0WbpxIa/XfOO4vegwpJIUFnFp7OSoKN3KSRUZ73sUrnqMAqx0moOc JyC/aLaIZ71r1gxHinAT/dp4m8NGsr5vrFvHZ61DejSshS7CA5fgx7tG+cCV+PPc okTdFpw+H14QeCakIhRYqPjJkNSuQQ94IvKL+46INoJpEUtYh/iUkvusAG9+Oo8y LXl4c/qy74Tz3//00dS/Qqi4Ay4/T4f2wON1EXr5Aqe8M6r2CQEJ/fOQrn9Bj9VN jljYv0x2fhZMYI9k3OXhjI75ArIeLV4xVS/Slo/44cVLquP4Q/y0xHD53vba/c3C ny9pPgnsg/n/TQpN//49 =qvce -----END PGP SIGNATURE----- --==========AD08069337EC5D173BDE==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?685BD37565065F0C493733CE>