From owner-svn-src-all@FreeBSD.ORG Sun Aug 8 21:41:59 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30E1D106567A; Sun, 8 Aug 2010 21:41:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id DECCA8FC29; Sun, 8 Aug 2010 21:41:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o78LceRq046532; Sun, 8 Aug 2010 15:38:40 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 08 Aug 2010 15:39:14 -0600 (MDT) Message-Id: <20100808.153914.769051483995699249.imp@bsdimp.com> To: gavin@FreeBSD.org From: "M. Warner Losh" In-Reply-To: References: <201008071608.o77G8bNN088653@svn.freebsd.org> <20100807.204946.244264502672924047.imp@bsdimp.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r211021 - head/sys/dev/usb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 21:41:59 -0000 In message: Gavin Atkinson writes: : On Sat, 7 Aug 2010, M. Warner Losh wrote: : > In message: <201008071608.o77G8bNN088653@svn.freebsd.org> : > Gavin Atkinson writes: : > : Author: gavin : > : Date: Sat Aug 7 16:08:37 2010 : > : New Revision: 211021 : > : URL: http://svn.freebsd.org/changeset/base/211021 : > : : > : Log: : > : Sort this file a little better: the vendors are supposed to be sorted by : > : vendor ID in the vendor section, and by symbolic name in the product : > : section. Products are sorted by product ID. While here, get rid of a : > : duplicate Microsoft Mouse entry, revealed by sorting. : > : > I thought products were sorted by the ID number, not the ID name. : : Yes, within a manufacturer, products should be sorted by ID. Each : manufacturer section is sorted by the symbolic manufacturer name, though. Within each product section, the products are sorted by numeric id, not symbolic id. That's how it was when I was maintaining this file, and is how pccarddevs also works. eg: product ALCOR SDCR_6335 0x6335 SD/MMC Card Reader product ALCOR SDCR_6362 0x6362 SD/MMC Card Reader product ALCOR TRANSCEND 0x6387 Transcend JetFlash Drive product ALCOR MA_KBD_HUB 0x9213 MacAlly Kbd Hub product ALCOR AU9814 0x9215 AU9814 Hub product ALCOR UMCR_9361 0x9361 USB Multimedia Card Reader product ALCOR SM_KBD 0x9410 MicroConnectors/StrongMan Keyboard product ALCOR NEC_KBD_HUB 0x9472 NEC Kbd Hub product ALCOR AU6390 0x6390 AU6390 USB-IDE converter has the last one out of order only (it should be sorted 4th in this list). : I'm not which one of us is misunderstanding the other - do you think my : change is somehow wrong? I think your change misorders things, unless I'm misreading it. It sorts based on symbolic ID rather than numeric ID. Warner