From owner-cvs-all  Sun May 27 16:26:16 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id C7AA937B422; Sun, 27 May 2001 16:26:11 -0700 (PDT)
	(envelope-from jesper@FreeBSD.org)
Received: (from jesper@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4RNQBG20221;
	Sun, 27 May 2001 16:26:11 -0700 (PDT)
	(envelope-from jesper)
Message-Id: <200105272326.f4RNQBG20221@freefall.freebsd.org>
From: Jesper Skriver <jesper@FreeBSD.org>
Date: Sun, 27 May 2001 16:26:11 -0700 (PDT)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/boot/common module.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

jesper      2001/05/27 16:26:11 PDT

  Modified files:
    sys/boot/common      module.c 
  Log:
  In sys/boot/common/module.c, near line 105 a request for a raw
  file is processed by passing its name in argv[1]:
          return(mod_loadobj(typestr, argv[1]));
  however, it is not tested to see if argv[1] actually is defined.
  
  At best, mod_loadobj() near line 244 returns an error like
  "can't find 'garbage'" but if the "filename" entered is sufficiently
  long, some buffer gets overrun. Of course, "load -t filename" is
  actually a typo because we meant to type "load -t mfs_root filename";
  nevertheless, a hung machine seems like too harsh a punishment for
  such a small typo...
  
  PR:			i386/27693
  Submitted by:	Adrian Steinmann <ast@marabu.ch>
  MFC after:	1 week
  
  Revision  Changes    Path
  1.19      +2 -2      src/sys/boot/common/module.c


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message