From owner-freebsd-current@FreeBSD.ORG Fri Jul 13 20:24:36 2007 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3594C16A404; Fri, 13 Jul 2007 20:24:36 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 585A113C4DA; Fri, 13 Jul 2007 20:24:35 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l6DKOXXC020108; Sat, 14 Jul 2007 00:24:33 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru; s=default; t=1184358274; bh=qqqn3KUQ+hwVHN251k1mH0eddIdgijVEjEKtLM5 A2Fo=; l=997; h=Received:Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=P4e766jyjWL9Ln9VAgHM a8tRuuLq7/2kZ+dhje/aQtqXLydtvpTdnvByoctAU006AWg0ch2k2GshjRbCCwL8e1r 3+I3OMepkvwaJucIxXosgXS+HD2R8zuFZt/AQwtuss+B4il0o4uVEMvM5IEU4H1kLaM H1YNO7qTs81SFgtgs= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l6DKOXKB020107; Sat, 14 Jul 2007 00:24:33 +0400 (MSD) (envelope-from ache) Date: Sat, 14 Jul 2007 00:24:33 +0400 From: Andrey Chernov To: "Sean C. Farley" Message-ID: <20070713202433.GA19856@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "Sean C. Farley" , freebsd-current References: <20070705105922.F98700@thor.farley.org> <20070707130859.GA96605@nagual.pp.ru> <20070707131359.GB96605@nagual.pp.ru> <20070707133102.C14065@thor.farley.org> <20070707191835.GA4368@nagual.pp.ru> <20070707205410.B14065@thor.farley.org> <20070708020940.GA80166@nagual.pp.ru> <20070708171727.GA90490@nagual.pp.ru> <20070713162742.GA16260@nagual.pp.ru> <20070713142545.K26096@thor.farley.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070713142545.K26096@thor.farley.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2007 20:24:36 -0000 On Fri, Jul 13, 2007 at 02:39:30PM -0500, Sean C. Farley wrote: > FreeBSD 6 will also dump if the length of the value was less than or > equal to "/bin" since it reuses this string. This will core dump: > > nenv[0] = "PATH=/bin"; > nenv[1] = NULL; > environ = nenv; > setenv("PATH", "/bin", 1); 1) I care in first hand about unsetenv() as my example states. There nowhere said in the specs that unsetenv() may modify environ _content_, manpage says about pointers only. 2) That example not fail under FreeBSD 6 but fail under new code: nenv[0] = "PATH=/bin"; nenv[1] = NULL; environ = nenv; setenv("HOME", "/xxx", 1); (that is because new code will touch "PATH=/bin" string in anycase while old ones looks for "HOME" only). The most safest way is do not touch environ content outside of scope of requested modification. That means I agree that nenv[0] = "PATH=/bin"; setenv("PATH", "/bin", 1); may fail, but not about the cases 1) and 2) -- http://ache.pp.ru/