From owner-cvs-src@FreeBSD.ORG Mon Dec 11 18:25:20 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B271716A49E; Mon, 11 Dec 2006 18:25:20 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3C0743E37; Mon, 11 Dec 2006 17:59:23 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kBBI0Zue047910; Mon, 11 Dec 2006 18:00:35 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kBBI0Zv0047909; Mon, 11 Dec 2006 18:00:35 GMT (envelope-from jkim) Message-Id: <200612111800.kBBI0Zv0047909@repoman.freebsd.org> From: Jung-uk Kim Date: Mon, 11 Dec 2006 18:00:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2006 18:25:20 -0000 jkim 2006-12-11 18:00:35 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: - Correct collision counter for BCM5705+. This register is read/clear. - Correct RX packet drop counter for BCM5705+. This register is read/clear and it wraps very quickly under heavy packet drops because only the lower ten bits are valid according to the documentation. However, it seems few more bits are actually valid and the rest bits are always zeros[1]. Therefore, we don't mask them off here. To get accurate packet drop count, we need to check the register from bge_rxeof(). It is commented out for now, not to penalize normal operation. Actual performance impact should be measured later. - Correct integer casting from u_long to uint32_t. Casting is not really needed for all supported platforms but we better do this correctly[2]. Tested by: bde[1] Suggested by: bde[2] Revision Changes Path 1.158 +13 -10 src/sys/dev/bge/if_bge.c