From owner-svn-src-all@FreeBSD.ORG  Fri Jul 23 19:29:56 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BD776106564A;
	Fri, 23 Jul 2010 19:29:56 +0000 (UTC) (envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31])
	by mx1.freebsd.org (Postfix) with ESMTP id 929638FC0A;
	Fri, 23 Jul 2010 19:29:56 +0000 (UTC)
Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1])
	by mail.cs.rice.edu (Postfix) with ESMTP id 0B3462C2A8C;
	Fri, 23 Jul 2010 14:29:56 -0500 (CDT)
X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu
Received: from mail.cs.rice.edu ([127.0.0.1])
	by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new,
	port 10024)
	with LMTP id YK-UEG7dP3Mt; Fri, 23 Jul 2010 14:29:48 -0500 (CDT)
Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net
	(adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.cs.rice.edu (Postfix) with ESMTP id F1ED42C2A92;
	Fri, 23 Jul 2010 14:29:47 -0500 (CDT)
Message-ID: <4C49EDAB.5020204@cs.rice.edu>
Date: Fri, 23 Jul 2010 14:29:47 -0500
From: Alan Cox <alc@cs.rice.edu>
User-Agent: Thunderbird 2.0.0.24 (X11/20100501)
MIME-Version: 1.0
To: Kostik Belousov <kostikbel@gmail.com>
References: <201007231858.o6NIwRR3087236@svn.freebsd.org>
	<20100723191808.GV2381@deviant.kiev.zoral.com.ua>
In-Reply-To: <20100723191808.GV2381@deviant.kiev.zoral.com.ua>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alan Cox <alc@freebsd.org>, svn-src-head@freebsd.org,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r210429 - in head/sys: amd64/linux32
 compat/freebsd32 kern sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jul 2010 19:29:56 -0000

Kostik Belousov wrote:
> On Fri, Jul 23, 2010 at 06:58:27PM +0000, Alan Cox wrote:
>   
>> Author: alc
>> Date: Fri Jul 23 18:58:27 2010
>> New Revision: 210429
>> URL: http://svn.freebsd.org/changeset/base/210429
>>
>> Log:
>>   Eliminate a little bit of duplicated code.
>>
>>     
> I think that amd64 copy of linux_exec_copyin_args() can go out as well.
> COMPAT_LINUX32 or linux.ko requires COMPAT_FREEBSD32, and the function
> seems to be identical to freebsd32_exec_copyin_args(), except there is
> missed check for fname != NULL.
>   

Do you want to delete it?  I would be happy for it to go away.

The reason that I was looking at this is that I'm tinkering with how we 
allocate memory for the exec strings because it accounts for > 2/3 of 
our system-wide TLB shootdowns in some workloads.