From owner-svn-src-all@FreeBSD.ORG  Thu Nov 14 19:10:14 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 950A3BF3;
 Thu, 14 Nov 2013 19:10:13 +0000 (UTC)
Message-ID: <52851F30.3030707@FreeBSD.org>
Date: Thu, 14 Nov 2013 14:06:24 -0500
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Sean Bruno <sbruno@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r258139 - head/contrib/gperf/src
References: <201311141841.rAEIfwFU040620@svn.freebsd.org>
In-Reply-To: <201311141841.rAEIfwFU040620@svn.freebsd.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Nov 2013 19:10:14 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-11-14 13:41:58 -0500, Sean Bruno wrote:
> Author: sbruno Date: Thu Nov 14 18:41:58 2013 New Revision: 258139 
> URL: http://svnweb.freebsd.org/changeset/base/258139
> 
> Log: Repair build after svn r258115
> 
> options.get_size_type() appears to return a const char *, so assume
> that its a string as oppose to *nothing*.  I have no idea what
> apple's code is trying to do here:
> 
> http://opensource.apple.com/source/gperf/gperf-9/patches/size_type.patch

It
> 
looks like the code is in fact unreachable, i.e., the language
option must be KRC, C, ANSIC, or CPLUSPLUS.  Therefore, the last test,
"option[ANSIC] | option[CPLUSPLUS]" is actually redundant.

I believe your correction is sufficient for now.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJShR8wAAoJEHyflib82/FGTlMH/3c6WrX6VPWJ1Xu9sF1wcT8n
S9VZG8RTY4KLc75oIAsvgc+970h7EWOhqNyNpI0JmayeW7OrG6Fqq7uT6EqtAU3i
iiYUXIW1tg5066G2VnnJW34z38Jv2V8DkjD7iF9ZdXnCMxS3tUdQiQMFCr2FKrJd
cT5+7z2+XvRq3QCT36hrSK65l3XDuUr08AVXxE9dJsReQoZMit9iHIctoJmGTqng
TaAuBiyKU7BG6Hr4hSbAni9XvzG7NRDOSU5Njc0QffRS3ZnyQZlEUAmD1f6uPUd6
ftPFIMZEk0hdCncWhKtT5HCxUyaw6RQPHF7ZRz3EmuDrxDu26qKIGAcmhizbwVg=
=tFjA
-----END PGP SIGNATURE-----