From owner-p4-projects@FreeBSD.ORG Sat Aug 26 23:47:16 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B064A16A4E0; Sat, 26 Aug 2006 23:47:16 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A71C16A4DD for ; Sat, 26 Aug 2006 23:47:16 +0000 (UTC) (envelope-from cognet@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5669843D45 for ; Sat, 26 Aug 2006 23:47:16 +0000 (GMT) (envelope-from cognet@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7QNlGDr033316 for ; Sat, 26 Aug 2006 23:47:16 GMT (envelope-from cognet@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7QNlGve033313 for perforce@freebsd.org; Sat, 26 Aug 2006 23:47:16 GMT (envelope-from cognet@freebsd.org) Date: Sat, 26 Aug 2006 23:47:16 GMT Message-Id: <200608262347.k7QNlGve033313@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to cognet@freebsd.org using -f From: Olivier Houchard To: Perforce Change Reviews Cc: Subject: PERFORCE change 105155 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2006 23:47:16 -0000 http://perforce.freebsd.org/chv.cgi?CH=105155 Change 105155 by cognet@cognet on 2006/08/26 23:46:40 The PCI bus will do the byte swapping for us, so there's no need to use le32toh and htole32. Affected files ... .. //depot/projects/arm/src/sys/arm/xscale/ixp425/ixp425_pci_space.c#3 edit Differences ... ==== //depot/projects/arm/src/sys/arm/xscale/ixp425/ixp425_pci_space.c#3 (text+ko) ==== @@ -295,7 +295,7 @@ u_int32_t data; data = _bs_r(v, ioh, off, 0); - return le32toh(data); + return (data); } #ifdef __ARMEB__ @@ -372,7 +372,7 @@ _pci_io_bs_w_4(void *v, bus_space_handle_t ioh, bus_size_t off, u_int32_t val) { - _bs_w(v, ioh, off, 0, htole32(val)); + _bs_w(v, ioh, off, 0,val); } #ifdef __ARMEB__ @@ -468,7 +468,7 @@ u_int32_t data; data = ixp425_pci_mem_bs_r_4(v, ioh, off); - return le32toh(data); + return (data); } static void @@ -489,7 +489,7 @@ _pci_mem_bs_w_4(void *v, bus_space_handle_t ioh, bus_size_t off, u_int32_t val) { - ixp425_pci_mem_bs_w_4(v, ioh, off, htole32(val)); + ixp425_pci_mem_bs_w_4(v, ioh, off, val); } #endif /* __ARMEB__ */