From owner-svn-ports-head@freebsd.org Thu Sep 8 14:03:19 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9C6ABD06EA; Thu, 8 Sep 2016 14:03:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9782DDC; Thu, 8 Sep 2016 14:03:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id n24so2563686pfb.2; Thu, 08 Sep 2016 07:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5/6DLiYOptoaU7pT9mywNL79bJIOJIS6hB4OuQvwVWk=; b=mtNhZMfVehMuCcelymB/YM5LQ3WqbWup8Io+/lPExE+mqrqWkMm6RyQVgAmDW9oZY+ EbXYgUTD/KW1PR5V8C97Cp6n3yFO1VLH+0aKwWbZyUGPeU8EyVuw+L8szrumaHMLpytJ e/VVbaTKEUGfNf7BvKi4eQwHOBS0gVvhjM7j+uzzBtRL00d+LXVaC3hrxobREjiKKasH XnKf/f39HsRf317ugMOEapW/mTV/+6xa3v57rGERG20jfYML1lEpGCG7qiQjYzNWKDOA DSkhn3k9lMgIbaNYOCQBejBRanL699Yc4noEcmy4nHKE5ibGneWtArKTlMXprr+gvBw8 4iaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5/6DLiYOptoaU7pT9mywNL79bJIOJIS6hB4OuQvwVWk=; b=MR3VMWusuMnIVu5suhzQImkT+D1PRiV4wMyanVPgnLuL4CCSZWhzdTJhsg5w2i/STA BtV+YZEpZWvCyC0vFDCyJME3kStKSaeVyXl8iPlwEy9av9RWWrIuGDbidb3+KqRZ/oYg AaXrcXzIZ3qgLe43fdppc7ZMtqTsoN7KtUf8u2YfS8B0iTbS27EwgiosubFxSqNqv6zp +gZCQc1jMVBv9pSXXTfIGV+4m3Nub0dkXz6lMnRXL/8QK5V0rNxnuDbrUzFC5GyCAXiR aZXyIKf0Ud4Uzg+bO8mEY8maaEBiLcpntaUXlaiOQHM/4IUfZDvRpKIoCFnY1YfoJpni fKtQ== X-Gm-Message-State: AE9vXwOWRI5R9lYbCgXWJhTGP39tz2bNYqGMw1XjaHCxv8g2fbTh1N4Wg5829V8pqxLNrw== X-Received: by 10.98.208.198 with SMTP id p189mr31590235pfg.71.1473343398705; Thu, 08 Sep 2016 07:03:18 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:5553:79b6:930e:e140? (2001-44b8-31ae-7b01-5553-79b6-930e-e140.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:5553:79b6:930e:e140]) by smtp.gmail.com with ESMTPSA id i73sm37875460pfi.35.2016.09.08.07.03.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2016 07:03:18 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r421549 - in head: . Mk References: <201609081315.u88DF6vL044982@repo.freebsd.org> To: Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Kubilay Kocak Message-ID: <190e2ef5-0f8c-efc3-bca1-7e5b541d3733@FreeBSD.org> Date: Fri, 9 Sep 2016 00:03:00 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Thunderbird/50.0a2 MIME-Version: 1.0 In-Reply-To: <201609081315.u88DF6vL044982@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 14:03:19 -0000 On 8/09/2016 11:15 PM, Dmitry Marakasov wrote: > Author: amdmi3 Date: Thu Sep 8 13:15:06 2016 New Revision: 421549 > URL: https://svnweb.freebsd.org/changeset/ports/421549 > > Log: Add support added for LICENSE=NONE, use it when the port > doesn't have cleanly defined licensing terms. Note that without > clean license allowing you to use and distribute the code it would be > be illegal to do so in many jurisdictions, so for ports with NONE > license no distfiles or packages are distributed. I'm glad this finally got added, though I'm worried that NONE is ambiguous and will unnecessarily cause otherwise package'able / distribute'able software to not be (inadvertently), and that None says more than we want its behaviour to mean. I truly do not intend to $bikeshed on the name, but are we saying: That ports with no *explicit* license terms should not be distributed/packaged by default? If so, shouldn't empty(LICENSE) do this? If all this does is avoid not having a whole bunch of existing ports not be packaged because they don't yet have LICENSE set, let's fix that. It's a great incentive to maintainers to get them added (explicitly). We could then even upgrade adding LICENSE to a requirement for ports rather than being optional (as it has been). What if a piece of software doesn't have 'cleanly' (what is the actual definition we should use?) defined license terms, but says/implies by some other method that it is free to be distributed/packaged? Say for example the software has debian/spec files in the sources but otherwise says nothing. Might LICENSE=UNDEFINED be a less ambiguous term/name for this "cant distribute/package because we want to be legally safe" behaviour? ./koobs > While here, fix trailing whitespace in CHANGES. > > Approved by: portmgr (bapt) Differential Revision: D7816 > > Modified: head/CHANGES head/Mk/bsd.licenses.db.mk > > Modified: head/CHANGES > ============================================================================== > > --- head/CHANGES Thu Sep 8 13:03:13 2016 (r421548) > +++ head/CHANGES Thu Sep 8 13:15:06 2016 (r421549) @@ -10,6 +10,15 > @@ in the release notes and/or placed into > > All ports committers are allowed to commit to this file. > > +20160908: +AUTHOR: amdmi3@FreeBSD.org + + Support has been added > for NONE license, use it when the port doesn't + have cleanly > defined licensing terms. Note that without clean license + allowing > you to use and distribute the code it would be be illegal to do + so > in many jurisdictions, so for ports with NONE license no distfiles > or + packages are distributed. + 20160824: AUTHOR: mat@FreeBSD.org > > @@ -39,16 +48,16 @@ AUTHOR: mat@FreeBSD.org 20160824: AUTHOR: > kde@FreeBSD.org > > - A new USES file has been introduced: USES=kde:4, which replaces > the old - bsd.kde4.mk file in preparation for upcoming KDE > Frameworks and Plasma5 - ports. - - Ports depending on KDE4 have to > switch from + A new USES file has been introduced: USES=kde:4, which > replaces the old + bsd.kde4.mk file in preparation for upcoming KDE > Frameworks and Plasma5 + ports. + + Ports depending on KDE4 have to > switch from USE_KDE4=foo bar - to + to USES=kde:4 USE_KDE=foo bar - > and make sure to switch from using KDE4_PREFIX to the new name > KDE_PREFIX + and make sure to switch from using KDE4_PREFIX to the > new name KDE_PREFIX in the Makefiles as well as plists. > > 20160821: > > Modified: head/Mk/bsd.licenses.db.mk > ============================================================================== > > --- head/Mk/bsd.licenses.db.mk Thu Sep 8 13:03:13 2016 (r421548) > +++ head/Mk/bsd.licenses.db.mk Thu Sep 8 13:15:06 2016 (r421549) @@ > -63,6 +63,9 @@ _LICENSE_LIST+= ART10 ARTPERL10 ART20 # PHP family > _LICENSE_LIST+= PHP202 PHP30 PHP301 > > +# Extras +_LICENSE_LIST+= NONE + # List of groups (only names must > be present) > > _LICENSE_NAME_FSF= Free Software Foundation Approved @@ -268,6 > +271,10 @@ _LICENSE_GROUPS_PSFL= FSF GPL OSI _LICENSE_NAME_RUBY= Ruby > License _LICENSE_GROUPS_RUBY= FSF > > +_LICENSE_NAME_NONE= No license specified +_LICENSE_GROUPS_NONE= # > empty +_LICENSE_PERMS_NONE= auto-accept + _LICENSE_NAME_ZLIB= zlib > License _LICENSE_GROUPS_ZLIB= GPL FSF OSI > >