From owner-cvs-all Mon Jan 14 0:51:33 2002 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id ABE4437B405; Mon, 14 Jan 2002 00:51:14 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g0E8p4588815; Mon, 14 Jan 2002 10:51:04 +0200 (EET) (envelope-from ru) Date: Mon, 14 Jan 2002 10:51:04 +0200 From: Ruslan Ermilov To: Alfred Perlstein Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/ipfilter/ipsend sock.c Message-ID: <20020114105104.B85961@sunbay.com> References: <200201140410.g0E4Aa763865@freefall.freebsd.org> <20020114161223.E4436-100000@gamplex.bde.org> <20020114103437.A85961@sunbay.com> <20020114004833.G7984@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020114004833.G7984@elvis.mu.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jan 14, 2002 at 12:48:33AM -0800, Alfred Perlstein wrote: > * Ruslan Ermilov [020114 00:35] wrote: > > On Mon, Jan 14, 2002 at 04:20:23PM +1100, Bruce Evans wrote: > > > On Sun, 13 Jan 2002, Alfred Perlstein wrote: > > > > > > > alfred 2002/01/13 20:10:36 PST > > > > > > > > Modified files: > > > > contrib/ipfilter/ipsend sock.c > > > > Log: > > > > add queue.h, now needed for file.h > > > > > > > > Revision Changes Path > > > > 1.9 +4 -1 src/contrib/ipfilter/ipsend/sock.c > > > > > > This is file.h's responsibility. file.h already includes queue.h, so > > > the problem must be elsewhere. Anyway, it is a bug if changes of > > > kernel implementation details affect prerequisites in applications. > > > > > Moving from after to before > > in file.h should fix the problem. > > *doh*, Now I'm a bit flustered, shall I go ahead and backout the > queue.h additions to userland and make this suggested change? > Definitely yes, as Bruce has already pointed out. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message