From owner-freebsd-stable Mon Jan 21 16: 5:50 2002 Delivered-To: freebsd-stable@freebsd.org Received: from prism.flugsvamp.com (66-188-92-95.mad.wi.charter.com [66.188.92.95]) by hub.freebsd.org (Postfix) with ESMTP id A1CA937B400; Mon, 21 Jan 2002 16:05:44 -0800 (PST) Received: (from jlemon@localhost) by prism.flugsvamp.com (8.11.6/8.11.6) id g0M01m840394; Mon, 21 Jan 2002 18:01:48 -0600 (CST) (envelope-from jlemon) Date: Mon, 21 Jan 2002 18:01:48 -0600 From: Jonathan Lemon To: Marko Zec Cc: "jlemon@freebsd.org" , Jun Kuriyama , freebsd-stable@freebsd.org Subject: Re: if_fxp.c typo? Message-ID: <20020121180148.U59128@prism.flugsvamp.com> References: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp> <7mn10ebxbp.wl@waterblue.imgsrc.co.jp> <3C4CA33C.BAD0F33B@tel.fer.hr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre2i In-Reply-To: <3C4CA33C.BAD0F33B@tel.fer.hr> Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jan 22, 2002 at 12:24:44AM +0100, Marko Zec wrote: > Hope this patch properly resolves the problem of unwanted resets of mcast > filters. However, when unloading the microcode, it is unavoidable to clear > the mcast filters, without making the code really complicated. This should > be probably stated in man-page as a kind of disclaimer... > Also, by this diff I suggest imposing a little bit more sane range limits > for int_delay and bundle_max. The multicast filter problem has already been resolved in r1.126 of the driver, by reloading the multicast filters on initialization. The value for bundle_max is explicitly allowed to go to 0xffff, from the Intel rcvbundl.h documentations: * .... If you do not want to put * a limit on the bundle size, set this value to xFFFF. The value for int_range is also correct, again from the Intel code: * .... The current default is either x600 or x800; * experiments show that the value probably should stay within the * range of x200 - x1000. There is an internal multiplier of 1.5 for the values, so a range of 300 - 3000 translates into 0x1C2 - 0x1194, with a default value of 0x5DC, which is "close enough". -- Jonathan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message