From nobody Wed Aug 5 15:16:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsj6dfYz6nQfv for ; Wed, 05 Aug 2026 15:16:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFYsj0ZnDz3w0M for ; Wed, 05 Aug 2026 15:16:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AHVCT74kEFvrQDtJi0YFRPX52JM6ykFcjMiW1gN+MjM=; b=oG4YaXVfezKGe2O6apn0j4DZBUYMPLvoUq9XvKXunQpOWAxYVJ/C7nnZOva+c4YiJjZSu/ IeBRanrmJDLb/r11+p/qqtSsruGZvTYtpiJ1YeLkcSVb8dB6JO2l8RxL5uATts90Wft3JH ys9cJ7nckwDDIlTGlFGPUMJLbOrNisPoKmHov3Xeae6EschY0lN4N3BIv3vaQknRP2YODY tVvAM/VwPMSolOBLsZLxLF9897FaVz6U3hOJObPjw3u8f/4hxbPdanVNFEag6VGQ7Oa9hU mf5CJYhY6HkiZv1ZC4A6m5sI1nqogVfiqhVTnlT+UByzyL5XbvtfGQCtV62Hhw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785943001; a=rsa-sha256; cv=none; b=cAh2uEEFjpEOcEXIcWqPbVbY8/f3JlKgy1c0WKnl/fo11iV35af4MOT3iNVtAJnT82rlJd OvKNIGT/2M1iVeqZ4vyG6LiYPf4FraQIfIGi8J3FEMZiWPj4sbmnNgoqBUcwFzdeDhD4ni HbgC3FCaTslSh/u+RiTV0dna+HfduzDVlhlj91obZFoQhM/oopqYMsszF4NWA2DXELe5gz vC2b2yemBsimb5wVEAJt4wAwSi6hvv80WAi6V7byN9x7BT64hBPgOqI9NRxgCsjAI6StE8 E5AE5YgnZSeV/5L/w802sGE0g3BEqXapVSKbRvcMtwEgMyEwxkxLybxTcAYgmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AHVCT74kEFvrQDtJi0YFRPX52JM6ykFcjMiW1gN+MjM=; b=oHJHiiAevPi4X5ghl+R0mivPDEn9WDsPT8CVSRxSJEOejWv2XFpZyW89i86/5g0vtRtUwE 67NMvUNB5TKRAgdbyzyQMPdzUIWhUUmSwZzRLWZpGOG/9RBF9rL8udhMwjtevRnyQrUPdE Cp4kHAJ+TrElDX8xtSjbKJIovyVlysntUhPASeSc7d+ofbXdGlqjxmOM9CpTNtk/gO/NCQ B8ZGwKCLv1DF4ls4bMq5rD26nT4D6q4V09q+2zWUHbpW9An0e9sfluC0FUnyyGTtrvxeF4 29yuVEPh35xbQXC3x+SaZMistzvBSfe4SNh06v8w16zHkCYEUdZKelA+CZTeng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsh6YpkzgKC for ; Wed, 05 Aug 2026 15:16:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 457fa by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 15:16:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 3e8d10f256d5 - stable/14 - inotify: Use memcmp() to compare embedded file names List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 3e8d10f256d5b2987370dbfefbca8c3f5f469113 Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 15:16:40 +0000 Message-Id: <6a7353d8.457fa.58b88193@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3e8d10f256d5b2987370dbfefbca8c3f5f469113 commit 3e8d10f256d5b2987370dbfefbca8c3f5f469113 Author: Mark Johnston AuthorDate: 2025-07-07 19:30:35 +0000 Commit: Mark Johnston CommitDate: 2026-08-05 15:15:16 +0000 inotify: Use memcmp() to compare embedded file names Otherwise gcc warns that strcmp() will read a byte from a zero-length array, though in practice we exclude that case with an explicit length check. Fixes: f1f230439fa4 ("vfs: Initial revision of inotify") (cherry picked from commit bc6b526e2b71cf7e07806db5bc77926ed5c874f7) --- sys/kern/vfs_inotify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/vfs_inotify.c b/sys/kern/vfs_inotify.c index 3542989c6a48..8c9e7599b888 100644 --- a/sys/kern/vfs_inotify.c +++ b/sys/kern/vfs_inotify.c @@ -500,7 +500,7 @@ inotify_can_coalesce(struct inotify_softc *sc, struct inotify_event *evp) return (prev != NULL && prev->ev.mask == evp->mask && prev->ev.wd == evp->wd && prev->ev.cookie == evp->cookie && prev->ev.len == evp->len && - (evp->len == 0 || strcmp(prev->ev.name, evp->name) == 0)); + memcmp(prev->ev.name, evp->name, evp->len) == 0); } static void