Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Jun 2022 13:31:44 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Ganael LAPLANCHE <martymac@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 7ca4bf132765 - main - devel/ncurses: Do not strip libraries when DEBUG option is set
Message-ID:  <Ypi7wHWf2LphTK22@FreeBSD.org>
In-Reply-To: <202206021021.252ALr89052824@gitrepo.freebsd.org>
References:  <202206021021.252ALr89052824@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 02, 2022 at 10:21:53AM +0000, Ganael LAPLANCHE wrote:
> commit 7ca4bf13276577544841a58c208e9b3fd7230b9a
> 
>   devel/ncurses: Do not strip libraries when DEBUG option is set
>     
> @@ -95,7 +95,9 @@ post-install:
>  	${RM} ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  	${ECHO} "INPUT(libncurses.so.${PORTVERSION:R} AS_NEEDED(-ltinfo))" > ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  
> +.if ! ${PORT_OPTIONS:MDEBUG}
>  	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so.${DISTVERSION}
> +.endif

Correct fix is to drop the DEBUG option and wrap --with-debug with
.if defined(WITH_DEBUG).  ${STRIP_CMD} respects WITH_DEBUG by itself
via Mk/b.p.m.  See `mail/mailutils' as an example.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Ypi7wHWf2LphTK22>