From owner-freebsd-current@freebsd.org Fri Nov 17 03:04:52 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B604DB86D5 for ; Fri, 17 Nov 2017 03:04:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qt0-x236.google.com (mail-qt0-x236.google.com [IPv6:2607:f8b0:400d:c0d::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 14DFB7731B; Fri, 17 Nov 2017 03:04:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qt0-x236.google.com with SMTP id e19so2811313qte.8; Thu, 16 Nov 2017 19:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=315L8ACJR/6vfr5mE8iUR9gQrddzmK8O3aqVDRXFwvw=; b=FDXHxvYiS7whJ0ZarEzvdB10FMs4yeU5EzNIYGe9c+WoTjs3HRgUpBzuozFxrYrnsa iMuyBZulgjE82SXRz8MDtFiMetjfNVnqlq+w5fztoHtpSXuAi/j8LzxN8oca5Z/Kp284 BH5g/EUFLX21tkEryx1ZVjcdZriF6c/E+B1omragQeMNv5lhZhAmV57oq6N8HV167GH2 BpXRTjnJmAmDPiICXQojY44ZqWdm13LBoIkJWRjkhq3EulijLRmazKyJH/qabY9Bzo3q sTDuSNnWN5eFvyYBPcfLPArwjHIfGnRav+H78nlKqwzxDtAj0tQ5Sn/7l6bKS+nUcVw7 QphA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=315L8ACJR/6vfr5mE8iUR9gQrddzmK8O3aqVDRXFwvw=; b=LMstlS0kUl5Q1ZrbSIv80sBRbXPwBuCZHiD8LtFQmam5hZnEOG2EFHnrSkd/t1o8ai SDA8DhiSemVWiF62d3LwyNbfxN5NZlKXkHcrdmMc0tDJ1byit18ck9lVxid8bQ1+LLRl UJM+Nlma7ees3tlKqGL7zk5U3rOxE0vqSwYovfJGyfDPC/+Z+2pQg+eGSdAJfCLHc6cx B9DOsIgifSBCHlRuWlZSRe8wZurKHqgYhQIy2iRTswnakCj6Zu8B+Mewr2e0O4irUXZf wq+3nFUN9hrsEZ1hdcfoK2dT3aOWMNC0seoaLZ2aRn6jRe+mRR6JQE9GnR5R1MFbtSA2 U7jQ== X-Gm-Message-State: AJaThX4c1oetSIm7OwBuzAdBybMNNS94Id6G7FftRRQ/f8N88K0Lxd5T G4GLyjrGLBVfScFPWtGiqCRexrUPHjUOaXmAPpqLJw== X-Google-Smtp-Source: AGs4zMZAfXDSWB/Y0ByhFdyNw/0IKuhELrdLROe8VeG8R4ARXL76GTn+Y42ol9oPeJC9Kog7vHznKuomVNwGZXQid8E= X-Received: by 10.55.111.3 with SMTP id k3mr5876316qkc.332.1510887891292; Thu, 16 Nov 2017 19:04:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.54.106 with HTTP; Thu, 16 Nov 2017 19:04:50 -0800 (PST) In-Reply-To: <1eb492f3-0a80-57f2-758c-6268c3b4c50b@protected-networks.net> References: <1eb492f3-0a80-57f2-758c-6268c3b4c50b@protected-networks.net> From: Mateusz Guzik Date: Fri, 17 Nov 2017 04:04:50 +0100 Message-ID: Subject: Re: SVN r325920 breaks build To: Michael Butler Cc: freebsd-current , Mateusz Guzik Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 03:04:52 -0000 Fixed in r325925, sorry. On Fri, Nov 17, 2017 at 3:56 AM, Michael Butler wrote: > As follows .. > > --- kern_mutex.o --- > /usr/src/sys/kern/kern_mutex.c:633:22: error: passing 'volatile struct > thread *' to parameter of type 'struct thread *' discards qualifiers > [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > turnstile_wait(ts, owner, TS_EXCLUSIVE_QUEUE); > ^~~~~ > /usr/src/sys/sys/turnstile.h:104:56: note: passing argument to parameter > here > void turnstile_wait(struct turnstile *, struct thread *, int); > ^ > /usr/src/sys/kern/kern_mutex.c:1013:2: error: use of undeclared > identifier 'v' > v = MTX_READ_VALUE(m); > ^ > /usr/src/sys/kern/kern_mutex.c:1015:6: error: use of undeclared > identifier 'v' > if (v & MTX_RECURSED) { > ^ > /usr/src/sys/kern/kern_mutex.c:1024:6: error: use of undeclared > identifier 'v' > if (v == tid && _mtx_release_lock(m, tid)) > ^ > 4 errors generated. > *** [kern_mutex.o] Error code 1 > > imb > -- Mateusz Guzik