From owner-svn-src-all@freebsd.org  Fri Jul 24 20:04:38 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 739579AA510;
 Fri, 24 Jul 2015 20:04:38 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6])
 by mx1.freebsd.org (Postfix) with ESMTP id 464A41C8B;
 Fri, 24 Jul 2015 20:04:37 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from [192.168.1.10] (unknown [192.168.1.10])
 (Authenticated sender: allanjude.freebsd@scaleengine.com)
 by mx1.scaleengine.net (Postfix) with ESMTPSA id A27D194DB;
 Fri, 24 Jul 2015 20:04:36 +0000 (UTC)
Subject: Re: svn commit: r285803 - head/bin/ls
To: Pedro Giffuni <pfg@FreeBSD.org>, Antoine Brodin <antoine@FreeBSD.org>
References: <201507221958.t6MJwLEk015409@repo.freebsd.org>
 <CAALwa8=yxd6+TmNgrFNwJP_ZAjHWLhdEqumfsPgf+PfWCn5pFw@mail.gmail.com>
 <55B28D93.5090003@freebsd.org> <55B294DB.9020000@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Allan Jude <allanjude@freebsd.org>
Message-ID: <55B29A4F.1070808@freebsd.org>
Date: Fri, 24 Jul 2015 16:04:31 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <55B294DB.9020000@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jul 2015 20:04:38 -0000

On 2015-07-24 15:41, Pedro Giffuni wrote:
>
>
> On 07/24/15 14:10, Allan Jude wrote:
>> ...
>
>>
>> The r285734 change didn't explicitly cast some references to uid_t,
>> resulting in a segfault on i386. Clang generated a warning about this
>> immediately while I was debugging when I duplicated the xo_emit
>> command as a printf.
>>
>> Can we teach our clang that xo_emit is printf, and so the same
>> formatting type matching should be checked? That would be very helpful.
>>
>
> Perhaps something like this? (untested)
>
> Pedro.
>
>

Yes, jhb@ pointed me in the same direction, and I have already submitted 
it upstream. It seems they already had it on some things, just not the 
most useful case.

https://github.com/Juniper/libxo/pull/45


-- 
Allan Jude